add application name as env var to driver and executor pods for SparkKubernetesOperator - #64015
Merged
Merged
Conversation
…KubernetesOperator - added spark application name to both driver and executor components in template body - custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var. - tests added accordingly -changelog.rst updated.
Shrividya
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
March 20, 2026 19:30
jscheffl
reviewed
Mar 20, 2026
|
@Shrividya Thanks, this will keep the driver and executor pod names consistent with this env var. Thanks for your contribution. |
Shrividya
force-pushed
the
add-spark-application-name
branch
from
March 20, 2026 22:17
43d4ca8 to
efdf49e
Compare
…KubernetesOperator - added spark application name to both driver and executor components in template body - custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var. - tests added accordingly -changelog.rst updated.
Shrividya
force-pushed
the
add-spark-application-name
branch
from
March 21, 2026 18:41
efdf49e to
449d3e1
Compare
jscheffl
marked this pull request as draft
March 22, 2026 08:41
Contributor
|
@Shrividya This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
Shrividya
marked this pull request as ready for review
March 22, 2026 21:11
jscheffl
approved these changes
Mar 22, 2026
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Crossing fingers CI is green, then good to merge in my view.
aaron-y-chen
pushed a commit
to aaron-y-chen/airflow
that referenced
this pull request
Mar 30, 2026
…KubernetesOperator (apache#64015) * add application name as env var to driver and executor pods for SparkKubernetesOperator - added spark application name to both driver and executor components in template body - custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var. - tests added accordingly -changelog.rst updated. * reverting the changelog * simplification of logic * add application name as env var to driver and executor pods for SparkKubernetesOperator - added spark application name to both driver and executor components in template body - custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var. - tests added accordingly -changelog.rst updated. * reverting the changelog * simplification of logic * Refactor expected_dict assignment for readability * Add mock patching to spark application name tests
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…KubernetesOperator (apache#64015) * add application name as env var to driver and executor pods for SparkKubernetesOperator - added spark application name to both driver and executor components in template body - custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var. - tests added accordingly -changelog.rst updated. * reverting the changelog * simplification of logic * add application name as env var to driver and executor pods for SparkKubernetesOperator - added spark application name to both driver and executor components in template body - custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var. - tests added accordingly -changelog.rst updated. * reverting the changelog * simplification of logic * Refactor expected_dict assignment for readability * Add mock patching to spark application name tests
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…KubernetesOperator (apache#64015) * add application name as env var to driver and executor pods for SparkKubernetesOperator - added spark application name to both driver and executor components in template body - custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var. - tests added accordingly -changelog.rst updated. * reverting the changelog * simplification of logic * add application name as env var to driver and executor pods for SparkKubernetesOperator - added spark application name to both driver and executor components in template body - custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var. - tests added accordingly -changelog.rst updated. * reverting the changelog * simplification of logic * Refactor expected_dict assignment for readability * Add mock patching to spark application name tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude(Anthropic) following the guidelines - used for review, debugging failing tests and suggesting fixes for test failures iteratively
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.