Skip to content

Update celery provider conf imports to use common compat SDK - #64134

Merged
jason810496 merged 2 commits into
apache:mainfrom
aaron-y-chen:tasksdk/migrate-conf-imports-celery
Mar 24, 2026
Merged

Update celery provider conf imports to use common compat SDK#64134
jason810496 merged 2 commits into
apache:mainfrom
aaron-y-chen:tasksdk/migrate-conf-imports-celery

Conversation

@aaron-y-chen

@aaron-y-chen aaron-y-chen commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

related: #60000

There are two files I did not migrate.

  1. celery/cli/definition.py
    It not allow to import from other path by below:

    # Allowed modules that can be imported in CLI definition files
    ALLOWED_MODULES = {
    "airflow.configuration",
    "airflow.cli.cli_config",
    }

    I think it should keep CLI startup lightweight, so I rolled it back.

  2. celery/cli/celery_command.py‎
    It seems the new config has no celery.pool option, so the unit test fails.

    if config.has_option("celery", "pool"):
    pool = config.get("celery", "pool")
    options.extend(["--pool", pool])

    Not sure if this is a bug.




Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Opus] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jason810496
jason810496 merged commit c09f02d into apache:main Mar 24, 2026
90 checks passed
@jason810496

jason810496 commented Mar 24, 2026

Copy link
Copy Markdown
Member

Sorry that I merged the PR too hastily. #64138 should fix this issue. Could you please help follow up on the remaining two CLI related files when you have time?

Thanks!

@aaron-y-chen

aaron-y-chen commented Mar 24, 2026 via email

Copy link
Copy Markdown
Contributor Author

@aaron-y-chen

Copy link
Copy Markdown
Contributor Author

Hi @jason810496, I opened an issue (#64201) for the celery_command.py bug. I'll handle the remaining two CLI related files after I solve this issue.

vatsrahul1001 pushed a commit that referenced this pull request Mar 25, 2026
* Update celery provider conf imports to use common compat SDK

* Keep cli files using airflow.configuration.conf
aaron-y-chen added a commit to aaron-y-chen/airflow that referenced this pull request Mar 30, 2026
…64134)

* Update celery provider conf imports to use common compat SDK

* Keep cli files using airflow.configuration.conf
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…64134)

* Update celery provider conf imports to use common compat SDK

* Keep cli files using airflow.configuration.conf
abhijeets25012-tech pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Apr 9, 2026
…64134)

* Update celery provider conf imports to use common compat SDK

* Keep cli files using airflow.configuration.conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants