Update celery provider conf imports to use common compat SDK - #64134
Merged
jason810496 merged 2 commits intoMar 24, 2026
Conversation
aaron-y-chen
requested review from
dheerajturaga and
hussein-awala
as code owners
March 24, 2026 04:12
Member
|
Sorry that I merged the PR too hastily. #64138 should fix this issue. Could you please help follow up on the remaining two CLI related files when you have time? Thanks! |
Contributor
Author
|
Sure, I’ll do that tomorrow I wake up 😄
…On Mon, Mar 23, 2026 at 11:51 PM Jason(Zhe-You) Liu < ***@***.***> wrote:
*jason810496* left a comment (apache/airflow#64134)
<#64134 (comment)>
Sorry that I merged the PR too hastily. #64138
<#64138> should fix this issue.
Could you please help follow up on the remaining two CLI related files
after #64138 <#64138> is merged,
when you have time?
Thanks!
—
Reply to this email directly, view it on GitHub
<#64134?email_source=notifications&email_token=ACW42LRASRMSPS6L6UDR2ND4SIWANA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJRGU4DINRTGMY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4115846331>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACW42LWKDYUMSRY3QPH6S3D4SIWANAVCNFSM6AAAAACW45U7J2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMJVHA2DMMZTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
Hi @jason810496, I opened an issue (#64201) for the |
vatsrahul1001
pushed a commit
that referenced
this pull request
Mar 25, 2026
* Update celery provider conf imports to use common compat SDK * Keep cli files using airflow.configuration.conf
aaron-y-chen
added a commit
to aaron-y-chen/airflow
that referenced
this pull request
Mar 30, 2026
…64134) * Update celery provider conf imports to use common compat SDK * Keep cli files using airflow.configuration.conf
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…64134) * Update celery provider conf imports to use common compat SDK * Keep cli files using airflow.configuration.conf
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…64134) * Update celery provider conf imports to use common compat SDK * Keep cli files using airflow.configuration.conf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #60000
There are two files I did not migrate.
celery/cli/definition.py
It not allow to import from other path by below:
airflow/scripts/ci/prek/check_cli_definition_imports.py
Lines 41 to 45 in 821a4ad
I think it should keep CLI startup lightweight, so I rolled it back.
celery/cli/celery_command.py
It seems the new config has no
celery.pooloption, so the unit test fails.airflow/providers/celery/src/airflow/providers/celery/cli/celery_command.py
Lines 293 to 295 in 4f2493d
Not sure if this is a bug.
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude Opus] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.