Skip to content

Flag ui-field-behaviour drift between hooks and provider.yaml in static checks - #72089

Closed
yuseok89 wants to merge 2 commits into
apache:mainfrom
yuseok89:check-ui-field-behaviour-drift
Closed

yuseok89 wants to merge 2 commits into
apache:mainfrom
yuseok89:check-ui-field-behaviour-drift

Conversation

@yuseok89

@yuseok89 yuseok89 commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

#72087 showed that ui-field-behaviour in provider.yaml can silently drift from get_ui_field_behaviour(), since the existing static check only covers conn-fields. This PR extends the check to also compare ui-field-behaviour (hidden fields, relabeling, placeholders), ignoring JSON formatting and whitespace-only differences.

depends on: #72087


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    • Fable 5

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@yuseok89 yuseok89 changed the title Flag ui-field-behaviour drift between hooks and provider.yaml in stat… (WIP) Flag ui-field-behaviour drift between hooks and provider.yaml in static checks Aug 26, 2026
@yuseok89 yuseok89 changed the title (WIP) Flag ui-field-behaviour drift between hooks and provider.yaml in static checks Flag ui-field-behaviour drift between hooks and provider.yaml in static checks Aug 28, 2026
@yuseok89
yuseok89 marked this pull request as ready for review August 28, 2026 01:00
@potiuk potiuk added the closed because of open PR limit Closed as a one-time step of introducing the open pull request limit label Sep 25, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @yuseok89 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 11 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants