Repository navigation
Add deadline alert coverage to Dag endpoint tests - #72296
Merged
shahar1 merged 1 commit intoOct 4, 2026
Merged
Conversation
Contributor
|
Does shivaam deserve co-author credit or is this a substantial change over the closed PR? |
ferruzzi
approved these changes
Sep 9, 2026
ferruzzi
left a comment
ferruzzi
left a comment
Contributor
There was a problem hiding this comment.
Couple nits, otherwise LGTM
ColtenOuO
force-pushed
the
add-deadline-alert-dag-endpoint-tests-50992
branch
from
September 9, 2026 16:52
96b9877 to
e3b86e6
Compare
Contributor
Author
Sure! I think this is worthful to add shivaam to co-author, because the overall logic was based on his implementation. |
Contributor
|
LGTM. Thanks for adding the tests |
Contributor
|
@bbovenzi - Did you ant to review this since it's touching the API? It's just adding additional testing, so shouldn't be a problem. |
shahar1
reviewed
Sep 18, 2026
shahar1
left a comment
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Could you please fix conflicts?
shahar1
changed the title
ColtenOuO
force-pushed
the
add-deadline-alert-dag-endpoint-tests-50992
branch
from
September 19, 2026 01:31
dfb0c46 to
43fb073
Compare
Contributor
Author
Sure! fixed it. |
This was referenced Sep 25, 2026
Closed
ColtenOuO
force-pushed
the
add-deadline-alert-dag-endpoint-tests-50992
branch
from
September 28, 2026 12:18
43fb073 to
6735cf0
Compare
The public Dag endpoint tests never exercised Dags with deadline alerts, leaving no coverage for how the API behaves when DagModel._deadline has data and SerializedDagModel.deadline_alerts has FK-linked records. closes: apache#50992 Co-Authored-By: Shivam Rastogi <6463385+shivaam@users.noreply.github.com>
ColtenOuO
force-pushed
the
add-deadline-alert-dag-endpoint-tests-50992
branch
from
September 28, 2026 15:09
6735cf0 to
5f2c56f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Although PR #64815 was closed, issue #50992 remains on the roadmap for AIP-86, so I've opened this PR to address it.
GET /dags,GET /dags/{id},GET /dags/{id}/details,PATCH /dags/{id},PATCH /dags, andDELETE /dags/{id}clear_db_deadlineandclear_db_deadline_alertto test cleanup to prevent FK constraint issuesDetails
The public DAG endpoint tests (
test_dags.py) never created DAGs with deadline alerts, so there wasno coverage for how the API behaves when
DagModel._deadlinehas data andSerializedDagModel.deadline_alertshas FK-linked records.7 new test methods across 6 test classes. No existing tests modified.
closes: #50992
Was generative AI tooling used to co-author this PR?