Repository navigation
Add Has Events filter to Assets search - #72460
Merged
Merged
Conversation
jasperjonkhans
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
henry3260,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
September 2, 2026 22:03
boring-cyborg
Bot
added
area:API
Contributor
|
Thanks, LGTM!! Just one nit. No behavior blocker from my side beyond that. |
pierrejeambrun
approved these changes
Sep 8, 2026
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Thanks for the pull request.
A couple of small nits, other looking good to me.
Large asset catalogs expose event activity only row by row, making it difficult to distinguish live assets from definitions that have never been updated.
The reviewer requested omitting a newsfragment for this change.
jasperjonkhans
force-pushed
the
issue-72281
branch
from
September 25, 2026 09:59
7585466 to
e7f2725
Compare
bbovenzi
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assets search now supports a tri-state
has_eventsquery parameter and exposes it as a URL-backed Has Events filter in the UI. This lets users distinguish assets with recorded events from definitions that have never emitted one and preserve or share the filtered view.The change:
closes: #72281
Was generative AI tooling used to co-author this PR?
Generated-by: Pi Coding Agent 0.84.4 following the guidelines