Repository navigation
Respect waiter_delay & waiter_max_attempts in EKS delete operators - #74000
Merged
Merged
Conversation
justinpakzad
marked this pull request as ready for review
October 1, 2026 02:02
justinpakzad
marked this pull request as draft
October 2, 2026 15:27
justinpakzad
force-pushed
the
forward-waiter-params-eks
branch
from
October 3, 2026 00:23
757c1b2 to
7477718
Compare
justinpakzad
marked this pull request as ready for review
October 3, 2026 00:57
vincbeck
approved these changes
Oct 13, 2026
vincbeck
left a comment
Contributor
There was a problem hiding this comment.
Agree, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
EksDeleteClusterOperatorandEksDeleteNodegroupOperatorboth acceptwaiter_delayandwaiter_max_attempts, but they were never forwarded to the waiters in the sync path. This PR propagates those values to the waiters. Forcluster_deletedandnodegroup_deletedthe waiter's default (30 delay, 40 attempts) matches the operators defaults. The two waiters reached via theforce_delete_compute=Truepath both default to 60 attempts and 30 delay so this would drop the total budget from 30 minutes to 20 minutes when the params aren't set. Additional tests were added to cover the new behavior and the asserts for two of the existing tests were updated.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.