Skip to content

Respect waiter_delay & waiter_max_attempts in EKS delete operators - #74000

Merged
vincbeck merged 1 commit into
apache:mainfrom
justinpakzad:forward-waiter-params-eks
Oct 13, 2026
Merged

vincbeck merged 1 commit into
apache:mainfrom
justinpakzad:forward-waiter-params-eks

Conversation

@justinpakzad

@justinpakzad justinpakzad commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

The EksDeleteClusterOperator and EksDeleteNodegroupOperator both accept waiter_delay and waiter_max_attempts, but they were never forwarded to the waiters in the sync path. This PR propagates those values to the waiters. For cluster_deleted and nodegroup_deleted the waiter's default (30 delay, 40 attempts) matches the operators defaults. The two waiters reached via the force_delete_compute=True path both default to 60 attempts and 30 delay so this would drop the total budget from 30 minutes to 20 minutes when the params aren't set. Additional tests were added to cover the new behavior and the asserts for two of the existing tests were updated.

Was generative AI tooling used to co-author this PR?
  • Yes (Claude Sonnet 5)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Oct 1, 2026
@justinpakzad
justinpakzad marked this pull request as ready for review October 1, 2026 02:02
@justinpakzad
justinpakzad marked this pull request as draft October 2, 2026 15:27
@justinpakzad
justinpakzad force-pushed the forward-waiter-params-eks branch from 757c1b2 to 7477718 Compare October 3, 2026 00:23
@justinpakzad
justinpakzad marked this pull request as ready for review October 3, 2026 00:57

@o-nikolas o-nikolas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the behaviour change here is fine, can count this as a bug fix. Thoughts @vincbeck

@vincbeck vincbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, thanks for the fix!

@vincbeck
vincbeck merged commit 9bcb6fd into apache:main Oct 13, 2026
162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants