Repository navigation
Use mask_secret from common.compat 1.22.0 in mcp hook - #75064
Merged
Lee-W merged 1 commit intoOct 21, 2026
Merged
Conversation
mattwang44
requested review from
Lee-W,
ashb,
gopidesupavan and
kaxil
as code owners
October 19, 2026 06:59
mattwang44
force-pushed
the
refactor-mcp-hook-mask-secret-compat
branch
from
October 19, 2026 06:59
2e09888 to
990b385
Compare
Lee-W
approved these changes
Oct 19, 2026
Member
|
@hussein-awala FYI, since you'll be handling the next provider release wave. I'm adding the |
Contributor
Author
|
rebasing it since the CI still failed due to not detecting the label (CI run), the code has not changed. |
Member
|
let me try to add it again |
Lee-W
added
allow provider dependency bump
and removed
allow provider dependency bump
labels
Lee-W
force-pushed
the
refactor-mcp-hook-mask-secret-compat
branch
from
October 19, 2026 08:31
990b385 to
09a7876
Compare
mattwang44
force-pushed
the
refactor-mcp-hook-mask-secret-compat
branch
from
October 21, 2026 05:55
09a7876 to
946bd05
Compare
Contributor
Author
|
another CI check seems to be flaky, rebased |
mattwang44
force-pushed
the
refactor-mcp-hook-mask-secret-compat
branch
from
October 21, 2026 07:11
946bd05 to
b4acc90
Compare
MCPHook carried its own three-level try/except to locate mask_secret across Airflow 2.11, 3.0 and 3.1+. common.compat 1.22.0 exports the same helper with the same fallback order, so the hook now imports it from airflow.providers.common.compat.sdk like the rest of the provider does. The common.compat floor moves to 1.22.0, the first release that exports mask_secret; with 1.21.x installed the import would fail.
mattwang44
force-pushed
the
refactor-mcp-hook-mask-secret-compat
branch
from
October 21, 2026 08:48
b4acc90 to
0a87af9
Compare
10 of 93 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring only, no behavior change.
MCPHook carried its own three-level try/except to import
mask_secretacross Airflow versions.common.compat1.22.0 exports the same helper with the same fallback order (#70766), so the hook now imports it from there like the rest of the provider.This PR raises
common.compatfloor to 1.22.0, the first release withmask_secret(so this needs theallow provider dependency bumplabel.)Was generative AI tooling used to co-author this PR?