[AMORO-4301][ams] Fix Kubernetes executor label prefix - #4302
Merged
Conversation
Use Spark's executor label prefix for optimizer executor pods and add regression coverage for both driver and executor labels.
zhoujinsong
approved these changes
Jul 30, 2026
zhoujinsong
left a comment
zhoujinsong
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Thanks for the fix.
xxubai
approved these changes
Jul 30, 2026
xxubai
pushed a commit
that referenced
this pull request
Jul 31, 2026
Use Spark's executor label prefix for optimizer executor pods and add regression coverage for both driver and executor labels. Co-authored-by: caosurong <surong.cao@thinkingdata.cn> Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com> (cherry picked from commit efbedc3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
KUBERNETES_EXECUTOR_LABEL_PREFIXcurrently uses the driver label prefix. Because Spark options are stored by key in a map, the intended executor entries overwrite the same driver keys and nospark.kubernetes.executor.label.*options are emitted. Executor pods therefore miss Amoro's optimizer labels for observability and label-based operations.Closes #4301.
Brief change log
spark.kubernetes.executor.label.for executor pod labels.How was this patch tested?
mvn test -pl amoro-ams -am -Dtest=TestSparkOptimizerContainer -Dsurefire.failIfNoSpecifiedTests=false -Pskip-dashboard-build(JDK 11; 5 tests passed).mvn validate -pl amoro-ams(JDK 11; Spotless and Checkstyle passed).Documentation