Repository navigation
Conversation
Fixes apache#1019 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1019
What
#950 restricted
externalTrafficPolicyin the gateway Service toLoadBalancerandNodePort, to fix #755 (the API server rejects the field on a plain ClusterIP Service). Kubernetes also accepts it on aClusterIPService withexternalIPs, where kube-proxy honors it, and setting it toLocalis the way to preserve the client source IP in that setup. Since 2.18.0 the field is silently dropped there and the Service falls back toCluster.This PR also renders the field when
service.externalIPsis set.Rendering (
helm template --show-only templates/service-gateway.yaml)type=ClusterIP,externalIPs={1.2.3.4},externalTrafficPolicy=LocalexternalTrafficPolicy: Localtype=ClusterIP, noexternalIPstype=NodePort,externalTrafficPolicy=LocalLocalLocaltype=NodePort)ClusterCluster🤖 Generated with Claude Code