Skip to content

chore: update reusability of some parameters, update versions of ingr… - #770

Open
ikatlinsky wants to merge 3 commits into
apache:masterfrom
ikatlinsky:chore/improve-extensibility-update-versions
Open

ikatlinsky wants to merge 3 commits into
apache:masterfrom
ikatlinsky:chore/improve-extensibility-update-versions

Conversation

@ikatlinsky

Copy link
Copy Markdown
Contributor

This pull request addresses 2 cases:

  1. Updating some of the configuration options to be rendered through the tpl directive, which is needed to improve configurability and reusability of the parameters when the values file is composed. Ideally all parameters should be migrated to this approach to make it more consistent and predictable.
    For example:

Ingress

  ingress:
    enabled: true
    annotations: 
      kubernetes.io/ingress.class: nginx 
    hosts:
      - host: "{{ tpl .Values.global.app.host . }}"
        paths:
          - "/"
    tls:
      - secretName: "{{ tpl .Values.global.config.secrets.tlsSecret . }}"
        hosts:
          - "{{ tpl .Values.global.app.host . }}"

External etcd

  externalEtcd:
    host:
      - "http://{{ tpl .Values.global.app.etcdHost . }}:2379"
    prefix: "/apisix"
    user: ""
  1. Updating the version of the dashboard and ingress controller images to the latest versions

@ikatlinsky

Copy link
Copy Markdown
Contributor Author

@Gallardot @AlinsRan please review

@ikatlinsky

Copy link
Copy Markdown
Contributor Author

@Gallardot @AlinsRan sorry for pinging, can you please check PR

@Gallardot

Copy link
Copy Markdown
Member

@Revolyssup @shreemaan-abhishek PTAL.

@ikatlinsky

Copy link
Copy Markdown
Contributor Author

@Revolyssup @shreemaan-abhishek up

1 similar comment
@ikatlinsky

Copy link
Copy Markdown
Contributor Author

@Revolyssup @shreemaan-abhishek up

@ikatlinsky

Copy link
Copy Markdown
Contributor Author

@ikatlinsky

Copy link
Copy Markdown
Contributor Author

1 similar comment
@ikatlinsky

Copy link
Copy Markdown
Contributor Author

@Gallardot Gallardot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikatlinsky

Copy link
Copy Markdown
Contributor Author

@Baoyuantop Baoyuantop added the question Further information is requested label Apr 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants