Skip to content

feat(c/driver/postgresql): add fixture-backed NUMERIC round-trip tests - #4536

Merged
lidavidm merged 4 commits into
apache:mainfrom
Mandukhai-Alimaa:feat/property-based-testing-for-numeric
Jul 20, 2026
Merged

feat(c/driver/postgresql): add fixture-backed NUMERIC round-trip tests#4536
lidavidm merged 4 commits into
apache:mainfrom
Mandukhai-Alimaa:feat/property-based-testing-for-numeric

Conversation

@Mandukhai-Alimaa

Copy link
Copy Markdown
Collaborator
  • Add adbc.postgresql.disable_decimal_fast_path, an undocumented option to disable the fast implementation as a test knob.
  • Add a script that generates a CSV fixture exhaustively enumerating every coefficient across all valid scales for a small precision, checked into the repo.
  • Add a round-trip test that ingests the fixture and asserts PostgreSQL echoes back the exact expected text, run once per path (fast/slow).

Closes #4528

@Mandukhai-Alimaa
Mandukhai-Alimaa requested a review from kou as a code owner July 16, 2026 17:43
Comment thread c/driver/postgresql/statement.h
Comment thread c/driver/postgresql/testdata/generate_numeric_roundtrip_fixtures.py Outdated
@lidavidm
lidavidm merged commit 5c80f65 into apache:main Jul 20, 2026
88 checks passed
@lidavidm lidavidm added this to the ADBC Libraries 24 milestone Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

c/driver/postgresql: test NUMERIC with property-based testing

2 participants