chore: Fix errors and compiler warnings on verification platforms - #420
Merged
Merged
Conversation
paleolimbot
marked this pull request as ready for review
April 9, 2024 18:48
lidavidm
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest verification run has a few outstanding errors ( https://github.com/apache/arrow-nanoarrow/actions/runs/8584808770/job/23525503382 ):
#include <array>This also fixes a mountain of compiler warnings because of
-Wmisleading-indentationon gcc that result from the flatcc generated header. These warnings made it difficult to find the Python test message error.There were also a few other compiler warnings that I noticed when compiling the tests with Meson. Meson compiles tests with
-Walland I don't think CMake compiles them with anything in particular (we do compile the C libraries with many warning flags).