Skip to content

Add type checking to JSON serializer - #850

Merged
pnoltes merged 2 commits into
masterfrom
feature/add-json-ser-type-checking
Sep 29, 2026
Merged

pnoltes merged 2 commits into
masterfrom
feature/add-json-ser-type-checking

Conversation

@pnoltes

@pnoltes pnoltes commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Add JSON type checking to the JSON (de-)serializer. Although remote services is based on trusted entities, type checking can help in finding bugs especially if messages interfaces are updated.

@codecov-commenter

codecov-commenter commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (270c784) to head (26adf35).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   91.54%   91.63%   +0.09%     
==========================================
  Files         235      235              
  Lines       28787    28826      +39     
==========================================
+ Hits        26353    26415      +62     
+ Misses       2434     2411      -23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PengZheng PengZheng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnoltes
pnoltes merged commit 0fff190 into master Sep 29, 2026
34 checks passed
@pnoltes
pnoltes deleted the feature/add-json-ser-type-checking branch September 29, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants