CLOUDSTACK-9756: Configure to ignore the ipassoc failure

[jayapalu]

On failure of ip assoc in back end (In VR), added config option to ignore or not to ignore failure. Using this failures won't be ignored and ip address will not set to free in DB.

[jayapalu]

Travis CI test_outofbandmanagement is failing which is not related to this PR changes. It seems there is problem with the test case.
@rhtyd Do you have any idea on this ?
Running tests: smoke/test_outofbandmanagement smoke/test_over_provisioning smoke/test_password_server smoke/test_portable_publicip smoke/test_primary_storage smoke/test_privategw_acl smoke/test_public_ip_range smoke/test_pvlan smoke/test_regions smoke/test_reset_vm_on_reboot smoke/test_resource_detail smoke/test_router_dhcphosts smoke/test_router_dns smoke/test_routers smoke/test_routers_iptables_default_policy smoke/test_routers_network_ops smoke/test_scale_vm smoke/test_secondary_storage smoke/test_service_offerings smoke/test_snapshots smoke/test_ssvm smoke/test_staticroles smoke/test_templates smoke/test_usage_events smoke/test_vm_life_cycle smoke/test_vm_snapshots smoke/test_volumes smoke/test_vpc_redundant smoke/test_vpc_router_nics smoke/test_vpc_vpn smoke/misc/test_deploy_vm smoke/misc/test_escalations_templates smoke/misc/test_vm_ha smoke/misc/test_vm_sync

Traceback (most recent call last):

File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 596, in process_request_thread

self.finish_request(request, client_address)

File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 331, in finish_request

self.RequestHandlerClass(request, client_address, self)

File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 652, in init

self.handle()

File "/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 436, in handle

return IpmiServerContext().handle(data, address, socket)

File "/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 112, in handle

self.initiate_session(data, address, self.session)

File "/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 143, in initiate_session

myaddr, netfnlun = struct.unpack('2B', data[14:16])

error: unpack requires a string argument of length 2

Traceback (most recent call last):

File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 596, in process_request_thread

self.finish_request(request, client_address)

File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 331, in finish_request

self.RequestHandlerClass(request, client_address, self)

File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 652, in init

self.handle()

File "/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 436, in handle

return IpmiServerContext().handle(data, address, socket)

File "/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 112, in handle

self.initiate_session(data, address, self.session)

File "/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 143, in initiate_session

myaddr, netfnlun = struct.unpack('2B', data[14:16])

error: unpack requires a string argument of length 2

[yadvr]

@jayapalu thanks, yes it seems an intermittent issue with ipmisim, pyghmi library that is used by the test to simulate a live ipmi server/board. I'll try to fix it soon, meanwhile you can push -f or close/open the PR to re-kick Travis.
Exception: Job failed: {jobprocstatus : 0, created : u'2017-02-09T13:17:54+0000', cmd : u'org.apache.cloudstack.api.command.admin.outofbandmanagement.ChangeOutOfBandManagementPasswordCmd', userid : u'9f69561f-eec8-11e6-8c34-42010a0a0806', jobstatus : 2, jobid : u'752cba20-e8f8-4b53-9675-8aa98186ee01', jobresultcode : 530, jobresulttype : u'object', jobresult : {errorcode : 530, errortext : u'Failed to change out-of-band management password for host (40328dc0-d290-481f-a6cc-f084ecf88661) due to driver error: Failed to find IPMI user to change password, error: > Error: no response from RAKP 1 message\n> Error: no response from RAKP 1 message\n> Error: no response from RAKP 1 message\n> Error: no response from RAKP 1 message\nSet Session Privilege Level to ADMINISTRATOR failed\nError: Unable to establish IPMI v2 / RMCP+ session\n'}, accountid : u'9f693066-eec8-11e6-8c34-42010a0a0806'}

[srinivas-gandikota]

The default for RulesContinueOnError is set to true, means the errors will be ignored.
Shouldn't the default be set to false ?

[jayapalu]

To continue with the existing behavior it is set to true. If some one want to enable they can set to false.

[srinivas-gandikota]

sound appropriate.

[srinivas-gandikota]

LGTM

[cloudmonger]

ACS CI BVT Run

Sumarry:
Build Number 417
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py

[kishankavala]

Code LGTM

[jayapalu]

There are two LGTMs and there are not test failures in the test results. So marking tag:mergeready

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-667

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1024)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35824 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1917-t1024-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 49 look ok, 3 have error(s)

Test	Result	Time (s)	Test File
test_04_rvpc_privategw_static_routes	Failure	295.56	test_privategw_acl.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	Error	0.00	test_deploy_virtio_scsi_vm.py
test_01_vpc_site2site_vpn	Success	165.37	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	Success	71.25	test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn	Success	246.24	test_vpc_vpn.py
test_02_VPC_default_routes	Success	254.22	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	Success	483.10	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	Success	508.67	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	Success	1403.30	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Success	538.48	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	Success	766.73	test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Success	1275.50	test_vpc_redundant.py
test_09_delete_detached_volume	Success	156.73	test_volumes.py
test_08_resize_volume	Success	156.66	test_volumes.py
test_07_resize_fail	Success	161.65	test_volumes.py
test_06_download_detached_volume	Success	156.36	test_volumes.py
test_05_detach_volume	Success	150.82	test_volumes.py
test_04_delete_attached_volume	Success	151.38	test_volumes.py
test_03_download_attached_volume	Success	156.35	test_volumes.py
test_02_attach_volume	Success	84.15	test_volumes.py
test_01_create_volume	Success	676.72	test_volumes.py
test_03_delete_vm_snapshots	Success	275.17	test_vm_snapshots.py
test_02_revert_vm_snapshots	Success	100.70	test_vm_snapshots.py
test_01_create_vm_snapshots	Success	133.76	test_vm_snapshots.py
test_deploy_vm_multiple	Success	257.79	test_vm_life_cycle.py
test_deploy_vm	Success	0.03	test_vm_life_cycle.py
test_advZoneVirtualRouter	Success	0.03	test_vm_life_cycle.py
test_10_attachAndDetach_iso	Success	26.93	test_vm_life_cycle.py
test_09_expunge_vm	Success	125.25	test_vm_life_cycle.py
test_08_migrate_vm	Success	30.91	test_vm_life_cycle.py
test_07_restore_vm	Success	0.13	test_vm_life_cycle.py
test_06_destroy_vm	Success	130.90	test_vm_life_cycle.py
test_03_reboot_vm	Success	125.94	test_vm_life_cycle.py
test_02_start_vm	Success	10.20	test_vm_life_cycle.py
test_01_stop_vm	Success	30.30	test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName	Success	85.87	test_templates.py
test_08_list_system_templates	Success	0.03	test_templates.py
test_07_list_public_templates	Success	0.04	test_templates.py
test_05_template_permissions	Success	0.09	test_templates.py
test_04_extract_template	Success	5.16	test_templates.py
test_03_delete_template	Success	5.13	test_templates.py
test_02_edit_template	Success	90.10	test_templates.py
test_01_create_template	Success	80.71	test_templates.py
test_10_destroy_cpvm	Success	161.76	test_ssvm.py
test_09_destroy_ssvm	Success	163.64	test_ssvm.py
test_08_reboot_cpvm	Success	131.47	test_ssvm.py
test_07_reboot_ssvm	Success	133.72	test_ssvm.py
test_06_stop_cpvm	Success	131.73	test_ssvm.py
test_05_stop_ssvm	Success	133.60	test_ssvm.py
test_04_cpvm_internals	Success	1.06	test_ssvm.py
test_03_ssvm_internals	Success	3.29	test_ssvm.py
test_02_list_cpvm_vm	Success	0.14	test_ssvm.py
test_01_list_sec_storage_vm	Success	0.14	test_ssvm.py
test_02_list_snapshots_with_removed_data_store	Success	81.95	test_snapshots.py
test_01_snapshot_root_disk	Success	11.77	test_snapshots.py
test_04_change_offering_small	Success	210.33	test_service_offerings.py
test_03_delete_service_offering	Success	0.04	test_service_offerings.py
test_02_edit_service_offering	Success	0.05	test_service_offerings.py
test_01_create_service_offering	Success	0.14	test_service_offerings.py
test_02_sys_template_ready	Success	0.14	test_secondary_storage.py
test_01_sys_vm_start	Success	0.20	test_secondary_storage.py
test_09_reboot_router	Success	40.34	test_routers.py
test_08_start_router	Success	30.28	test_routers.py
test_07_stop_router	Success	10.17	test_routers.py
test_06_router_advanced	Success	0.09	test_routers.py
test_05_router_basic	Success	0.04	test_routers.py
test_04_restart_network_wo_cleanup	Success	5.71	test_routers.py
test_03_restart_network_cleanup	Success	60.54	test_routers.py
test_02_router_internal_adv	Success	1.16	test_routers.py
test_01_router_internal_basic	Success	0.69	test_routers.py
test_router_dns_guestipquery	Success	76.86	test_router_dns.py
test_router_dns_externalipquery	Success	0.07	test_router_dns.py
test_router_dhcphosts	Success	237.00	test_router_dhcphosts.py
test_router_dhcp_opts	Success	21.85	test_router_dhcphosts.py
test_01_updatevolumedetail	Success	0.11	test_resource_detail.py
test_01_reset_vm_on_reboot	Success	131.18	test_reset_vm_on_reboot.py
test_createRegion	Success	0.05	test_regions.py
test_create_pvlan_network	Success	5.26	test_pvlan.py
test_dedicatePublicIpRange	Success	0.51	test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup	Success	475.94	test_privategw_acl.py
test_02_vpc_privategw_static_routes	Success	340.42	test_privategw_acl.py
test_01_vpc_privategw_acl	Success	92.47	test_privategw_acl.py
test_03_migration_options_storage_tags	Success	66.23	test_primary_storage.py
test_02_edit_primary_storage_tags	Success	0.17	test_primary_storage.py
test_01_primary_storage_nfs	Success	35.83	test_primary_storage.py
test_01_deploy_vms_storage_tags	Success	31.17	test_primary_storage.py
test_createPortablePublicIPRange	Success	10.27	test_portable_publicip.py
test_createPortablePublicIPAcquire	Success	15.63	test_portable_publicip.py
test_isolate_network_password_server	Success	89.45	test_password_server.py
test_UpdateStorageOverProvisioningFactor	Success	0.16	test_over_provisioning.py
test_oobm_zchange_password	Success	30.69	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	Success	16.39	test_outofbandmanagement.py
test_oobm_issue_power_status	Success	10.30	test_outofbandmanagement.py
test_oobm_issue_power_soft	Success	10.34	test_outofbandmanagement.py
test_oobm_issue_power_reset	Success	15.36	test_outofbandmanagement.py
test_oobm_issue_power_on	Success	15.38	test_outofbandmanagement.py
test_oobm_issue_power_off	Success	10.36	test_outofbandmanagement.py
test_oobm_issue_power_cycle	Success	15.36	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	Success	82.77	test_outofbandmanagement.py
test_oobm_enable_feature_valid	Success	5.18	test_outofbandmanagement.py
test_oobm_enable_feature_invalid	Success	0.12	test_outofbandmanagement.py
test_oobm_disable_feature_valid	Success	5.21	test_outofbandmanagement.py
test_oobm_disable_feature_invalid	Success	0.13	test_outofbandmanagement.py
test_oobm_configure_invalid_driver	Success	0.09	test_outofbandmanagement.py
test_oobm_configure_default_driver	Success	0.10	test_outofbandmanagement.py
test_oobm_background_powerstate_sync	Success	23.45	test_outofbandmanagement.py
test_extendPhysicalNetworkVlan	Success	15.34	test_non_contigiousvlan.py
test_01_nic	Success	419.44	test_nic.py
test_releaseIP	Success	147.38	test_network.py
test_reboot_router	Success	373.63	test_network.py
test_public_ip_user_account	Success	10.32	test_network.py
test_public_ip_admin_account	Success	40.31	test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule	Success	66.68	test_network.py
test_network_rules_acquired_public_ip_2_nat_rule	Success	61.75	test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule	Success	123.36	test_network.py
test_delete_account	Success	272.94	test_network.py
test_02_port_fwd_on_non_src_nat	Success	55.73	test_network.py
test_01_port_fwd_on_src_nat	Success	111.93	test_network.py
test_nic_secondaryip_add_remove	Success	202.77	test_multipleips_per_nic.py
test_list_zones_metrics	Success	0.29	test_metrics_api.py
test_list_volumes_metrics	Success	5.59	test_metrics_api.py
test_list_vms_metrics	Success	191.90	test_metrics_api.py
test_list_pstorage_metrics	Success	0.42	test_metrics_api.py
test_list_infrastructure_metrics	Success	0.52	test_metrics_api.py
test_list_hosts_metrics	Success	0.41	test_metrics_api.py
test_list_clusters_metrics	Success	0.33	test_metrics_api.py
login_test_saml_user	Success	20.54	test_login.py
test_assign_and_removal_lb	Success	133.42	test_loadbalance.py
test_02_create_lb_rule_non_nat	Success	187.38	test_loadbalance.py
test_01_create_lb_rule_src_nat	Success	217.71	test_loadbalance.py
test_03_list_snapshots	Success	0.09	test_list_ids_parameter.py
test_02_list_templates	Success	0.04	test_list_ids_parameter.py
test_01_list_volumes	Success	0.10	test_list_ids_parameter.py
test_07_list_default_iso	Success	0.07	test_iso.py
test_05_iso_permissions	Success	0.07	test_iso.py
test_04_extract_Iso	Success	5.16	test_iso.py
test_03_delete_iso	Success	95.13	test_iso.py
test_02_edit_iso	Success	0.06	test_iso.py
test_01_create_iso	Success	21.08	test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	Success	197.95	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	Success	148.19	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	Success	511.54	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	Success	427.61	test_internal_lb.py
test_dedicateGuestVlanRange	Success	10.40	test_guest_vlan_range.py
test_UpdateConfigParamWithScope	Success	0.14	test_global_settings.py
test_rolepermission_lifecycle_update	Success	6.33	test_dynamicroles.py
test_rolepermission_lifecycle_list	Success	6.09	test_dynamicroles.py
test_rolepermission_lifecycle_delete	Success	5.91	test_dynamicroles.py
test_rolepermission_lifecycle_create	Success	5.95	test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates	Success	6.12	test_dynamicroles.py
test_role_lifecycle_update_role_inuse	Success	6.08	test_dynamicroles.py
test_role_lifecycle_update	Success	11.19	test_dynamicroles.py
test_role_lifecycle_list	Success	6.00	test_dynamicroles.py
test_role_lifecycle_delete	Success	11.00	test_dynamicroles.py
test_role_lifecycle_create	Success	5.97	test_dynamicroles.py
test_role_inuse_deletion	Success	5.94	test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers	Success	8.35	test_dynamicroles.py
test_role_account_acls	Success	8.70	test_dynamicroles.py
test_default_role_deletion	Success	6.02	test_dynamicroles.py
test_04_create_fat_type_disk_offering	Success	0.09	test_disk_offerings.py
test_03_delete_disk_offering	Success	0.05	test_disk_offerings.py
test_02_edit_disk_offering	Success	0.06	test_disk_offerings.py
test_02_create_sparse_type_disk_offering	Success	0.09	test_disk_offerings.py
test_01_create_disk_offering	Success	0.12	test_disk_offerings.py
test_deployvm_userdispersing	Success	20.65	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	Success	20.62	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit	Success	70.91	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post	Success	10.49	test_deploy_vm_with_userdata.py
test_deployvm_userdata	Success	50.84	test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize	Success	6.09	test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize	Success	6.09	test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize	Success	227.84	test_deploy_vm_root_resize.py
test_deploy_vm_from_iso	Success	207.67	test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup	Success	91.24	test_affinity_groups.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.02	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.05	test_primary_storage.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_deploy_vgpu_enabled_vm	Skipped	0.04	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.04	test_deploy_vgpu_enabled_vm.py