Skip to content

Benchmark and optimize CAST from String to Integer #330

Description

@andygrove

What is the problem the feature request solves?

#307 fixes a correctness issue with casting from string to integer, but there is a question about performance in #307 (comment).

This issue is for benchmarking the native CAST operation versus Spark as well as looking at optimizing the code.

Another area that could be optimized would be to avoid converting a string to a Vec<char> in do_cast_string_to_int:

let chars: Vec<char> = str.chars().collect();

We should be able to just use iterators over the underlying chars but we have to iterate from both start and end of the string, so it isn't trivial.

Describe the potential solution

No response

Additional context

No response

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions