Skip to content

Kubernetes guide example never enables Comet because it sets no off-heap memory #6190

Description

@andygrove

Describe the bug

The Spark Operator example in the Kubernetes guide (kubernetes.md#L61-L100) enables Comet through spark.plugins, but it does not set spark.memory.offHeap.enabled or spark.memory.offHeap.size. CometDriverPlugin therefore logs "Comet plugin is disabled because Spark is not running in off-heap mode", and the application runs without Comet. The example also sets no spark.executor.memoryOverhead, which the tuning guide says Comet needs. Kubernetes is where that matters most, because the pod limit is enforced.

There are two more problems with the same example. It mixes versions: the image and the extra class path are Spark 3.5 with Scala 2.12, but mainApplicationFile is spark-examples_2.13-4.1.3.jar and sparkVersion is 4.1.3. And SparkPi only uses RDDs, so it would not exercise Comet even with the plugin loaded.

Expected behavior

The example sets off-heap memory and the memory overhead, uses consistent versions, and runs a workload that Comet accelerates.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationenhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions