Conversation
wForget
force-pushed
the
COMET-1726
branch
2 times, most recently
from
May 12, 2025 06:14
acc69e9 to
0ab48f9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
============================================
+ Coverage 56.12% 58.68% +2.55%
- Complexity 976 1137 +161
============================================
Files 119 129 +10
Lines 11743 12687 +944
Branches 2251 2373 +122
============================================
+ Hits 6591 7445 +854
- Misses 4012 4056 +44
- Partials 1140 1186 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1733.
Rationale for this change
The memory acquired by
CometMemoryPool.growmay be less than the actual request, soCometMemoryPool.shrinkmay release more memory than acquired memory.datafusion-comet/native/core/src/execution/memory_pools/unified_pool.rs
Lines 93 to 95 in 25e39ab
What changes are included in this PR?
Add an acquired counter to avoid releasing more unacquired memory
How are these changes tested?