Skip to content

test: name the whole dispatched subtree in the decimal promotion assertion #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 1 commit into from
Sep 10, 2026
Merged

test: name the whole dispatched subtree in the decimal promotion assertion #5849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions spark/src/test/scala/org/apache/comet/CometCodegenSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,13 +422,21 @@ class CometCodegenSuite

// Promotion rebuilds Hypot as well as the Alias above it. Unlike the original Add, the
// dispatched copy is not reachable from the original tree, so only the coverage lift can
// bring its name back to the projection owner.
// bring its names back to the projection owner.
//
// Every expression in the rebuilt subtree is named, not just the dispatched root: the whole
// subtree was bound into the one kernel, so all of it ran in the JVM. `checkoverflow` is the
// wrapper promotion added around the decimal `Add`, which is what makes the lifted set
// evidence that the promoted copy, rather than the original tree, was the one recorded.
val proto = QueryPlanSerde.exprToProto(projection, Seq(decimal)).get
assert(proto.hasJvmScalarUdf)
assert(proto.getJvmScalarUdf.getClassName === classOf[CometScalaUDFCodegen].getName)
assert(dispatched.getTagValue(CometExplainInfo.DISPATCHED_SELF).isEmpty)
assert(dispatched.getTagValue(CometExplainInfo.CODEGEN_DISPATCH_EXPRS).isEmpty)
assert(projection.getTagValue(CometExplainInfo.CODEGEN_DISPATCH_EXPRS).contains(Set("hypot")))
assert(
projection
.getTagValue(CometExplainInfo.CODEGEN_DISPATCH_EXPRS)
.contains(Set("hypot", "cast", "checkoverflow", "add")))
}

test("tags copied onto the shared TrueLiteral do not leak into unrelated plans") {
Expand Down
Loading