Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5519.
Rationale for this change
Spark 4.1 enables the whole-value Variant scan rewrite by default, which currently forces Comet to fall back.
What changes are included in this PR?
Recognize Spark's single full-Variant request, reuse the native normalizer, and preserve the wrapper's metadata and nulls through serialization and FFI. Update the Variant support documentation.
How are these changes tested?
Native Parquet and Comet Variant tests cover canonical and shredded values, nulls, metadata, unsupported requests, and reader guards. Selected upstream Spark 4.1.3 assertions also pass with the native rewrite enabled.
The broader native run has a timing-sensitive failure in the unchanged S3 credential refresh test, which passes in isolation.
Draft pending broader Spark CI: please apply
run-spark-4.1-testsandrun-all-spark-profilesbefore marking ready for review.