Skip to content

Extract common aggregation spill logic #24317

Closed

Description

@2010YOUY01

Is your feature request related to a problem or challenge?

The spilling path added for OrderedSingleAggregateStream in #24259 is largely similar to the spilling paths used by other aggregation modes. Keeping separate copies of the same spill mechanics makes future fixes and changes easier to miss and can cause the implementations to drift.

This is follow-up work from #24259 (comment) and part of #22710.

Describe the solution you'd like

Identify the semantically identical parts of the aggregation spilling paths and extract them into shared logic that can be reused by the relevant aggregation streams.

Keep mode-specific policies and state transitions explicit in each dedicated stream; only the common spill mechanics should be shared.

Describe alternatives you've considered

Additional context

Activity

  1. self-assigned this
    on Aug 13, 2026
  2. 2010YOUY01 commented on Sep 22, 2026

    @2010YOUY01
    ContributorAuthor

    Closed by #25538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions