chore: Define backport criteria#22766
Merged
Merged
Conversation
github-actions
Bot
added
the
documentation
alamb
approved these changes
Jun 8, 2026
| ### Behavior changes | ||
|
|
||
| A "behavior change" is any fix that alters user-visible results: SQL | ||
| semantics (values, ordering, types, null handling), error messages that |
Contributor
There was a problem hiding this comment.
I think we have made error message changes in minor releases before and it seems like that would be ok to me, to be honest.
The rest of this sounds good
Comment on lines
+112
to
+118
| returning different results. Before opening the backport PR: | ||
|
|
||
| 1. State on the release tracking issue _why_ the change must ship in this | ||
| patch release rather than the next major. | ||
| 2. Describe the previous and new behavior with example queries and results. | ||
| 3. Wait for explicit acknowledgment from the release manager or another | ||
| committer on the tracking issue. |
Contributor
There was a problem hiding this comment.
I am not sure we need to gate the creation of a backport PR on acknowledgement from the release manager -- making the backport PR is pretty simple, and I would expect that 2. (describing previous behavior, etc) would have already been done on the main issue
Explaining why you want the change in the patch release is a good idea though.
|
|
||
| ### Who decides | ||
|
|
||
| The release manager for the active release line is the final reviewer of |
Contributor
There was a problem hiding this comment.
I think practically any committer can commit to a release branch too -- so maybe we can make ti clear that others can merge PRs to the release branch, though the release manager will review them
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
EdsonPetry
pushed a commit
to EdsonPetry/datafusion
that referenced
this pull request
Jun 9, 2026
…22822) ## Which issue does this PR close? - Part of apache#22765 - Related to apache#19783. ## Rationale for this change While reviewing apache#22766 from @comphead I noticed that the release management guide did not point contributors to the ongoing release tracking issue, where planned releases are listed. ## What changes are included in this PR? This PR adds a link to the DataFusion Releases tracking issue from the release management guide and clarifies that each release is coordinated in a dedicated GitHub issue. ## Are these changes tested? Not run. This is a documentation-only change. ## Are there any user-facing changes? No API or behavior changes. This updates contributor documentation only.
Contributor
Author
|
Concern we running code CI for documentation PRs, which doesn't make a lot of sense. |
Contributor
Author
|
Thanks @alamb for the review |
AdamGS
pushed a commit
to AdamGS/arrow-datafusion
that referenced
this pull request
Jun 11, 2026
…22822) ## Which issue does this PR close? - Part of apache#22765 - Related to apache#19783. ## Rationale for this change While reviewing apache#22766 from @comphead I noticed that the release management guide did not point contributors to the ongoing release tracking issue, where planned releases are listed. ## What changes are included in this PR? This PR adds a link to the DataFusion Releases tracking issue from the release management guide and clarifies that each release is coordinated in a dedicated GitHub issue. ## Are these changes tested? Not run. This is a documentation-only change. ## Are there any user-facing changes? No API or behavior changes. This updates contributor documentation only.
AdamGS
pushed a commit
to AdamGS/arrow-datafusion
that referenced
this pull request
Jun 11, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#22765 . ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?