minor: handle NULL array input in array_remove and array_replace#22790
Merged
Conversation
github-actions
Bot
added
sqllogictest
Jefffrey
approved these changes
Jun 8, 2026
| @@ -65,11 +65,36 @@ select | |||
|
|
|||
| #TODO: https://github.com/apache/datafusion/issues/7142 | |||
Contributor
There was a problem hiding this comment.
do we still need to address this comment?
Contributor
Author
There was a problem hiding this comment.
NULL handling looks complete here, this comment can be cleaned up. #7142 is still tracked in other files, so we're not losing the reference.
AdamGS
pushed a commit
to AdamGS/arrow-datafusion
that referenced
this pull request
Jun 11, 2026
…che#22790) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> `array_remove` errored out when given a `NULL` array argument. `array_replace` handled the `DataType::Null` case, but it always built a NULL array of length 1, regardless of the actual input length. `remove` and `replace` share nearly identical implementations, so they should treat a NULL array argument the same way ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - `array_remove`: handle `DataType::Null` in both `array_remove_internal` and the scalar fast-path `array_remove_with_scalar_args`, returning a NULL array of the input length. - `array_replace`: fix the existing `DataType::Null` branches to use the input array length (`array.len()` / `list_array.len()`) instead of a hard-coded `1`. ## Are these changes tested? Yes, added slt coverage <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? `array_remove`/`array_remove_n`/`array_remove_all` now return `NULL` for a `NULL`-typed array argument instead of raising an error. No breaking API changes. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
array_removeerrored out when given aNULLarray argument.array_replacehandled theDataType::Nullcase, but it always built a NULL array of length 1, regardless of the actual input length.removeandreplaceshare nearly identical implementations, so they should treat a NULL array argument the same wayWhat changes are included in this PR?
array_remove: handleDataType::Nullin botharray_remove_internaland the scalar fast-patharray_remove_with_scalar_args, returning a NULL array of the input length.array_replace: fix the existingDataType::Nullbranches to use the input array length (array.len()/list_array.len()) instead of a hard-coded1.Are these changes tested?
Yes, added slt coverage
Are there any user-facing changes?
array_remove/array_remove_n/array_remove_allnow returnNULLfor aNULL-typed array argument instead of raising an error. No breaking API changes.