Fix topk emitted batches metric - #24481
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24481 +/- ##
==========================================
- Coverage 81.45% 81.45% -0.01%
==========================================
Files 1118 1118
Lines 399555 399627 +72
Branches 399555 399627 +72
==========================================
+ Hits 325462 325516 +54
- Misses 55097 55107 +10
- Partials 18996 19004 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 20, 2026
alamb
approved these changes
Aug 20, 2026
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @cetra3 and @jayzhan211
Dandandan
enabled auto-merge
August 20, 2026 20:54
kumarUjjawal
disabled auto-merge
August 22, 2026 07:43
kumarUjjawal
enabled auto-merge
August 22, 2026 07:43
Contributor
|
hmm! there seems to be some issue with spark actions. I will manually trigger the re-run see if that fixes it. |
kumarUjjawal
disabled auto-merge
August 22, 2026 07:52
Contributor
|
@cetra3 looks like you will have to rebase with main once. |
jayzhan211
enabled auto-merge
August 24, 2026 13:19
auto-merge was automatically disabled
August 26, 2026 01:21
Head branch was pushed to by a user without write access
cetra3
force-pushed
the
fix_topk_emitted_batches
branch
from
August 26, 2026 01:21
e88598c to
021451f
Compare
kumarUjjawal
approved these changes
Aug 26, 2026
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you @cetra3 for resolving the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
output_batchesmetric does not match the number of emitted batches #24468metrics()returnsNone) #24470Rationale for this change
Fixes some issues around metrics and TopK execution nodes
What changes are included in this PR?
Adjusts to include metrics in PartitionedTopKExec and also fixes the batch count in TopK
Are these changes tested?
Yes new tests added.
Are there any user-facing changes?
No new traits, etc.. just fixes some bugs on the physical plan side