Repository navigation
ci: Ensure only the main datafusion crate is used in the examples - #25777
Merged
Merged
Conversation
github-actions
Bot
added
the
development-process
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25777 +/- ##
==========================================
+ Coverage 82.49% 82.51% +0.01%
==========================================
Files 1140 1141 +1
Lines 438555 439780 +1225
Branches 438555 439780 +1225
==========================================
+ Hits 361803 362885 +1082
- Misses 54880 54952 +72
- Partials 21872 21943 +71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Here's what happens when |
nuno-faria
marked this pull request as ready for review
September 26, 2026 16:07
alamb
approved these changes
Sep 27, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks great to me. Thank you @nuno-faria
Do we also need to add this to the list of required checks here:
Line 55 in f029b94
?
Omega359
pushed a commit
to Omega359/arrow-datafusion
that referenced
this pull request
Oct 11, 2026
…ache#25777) ## Which issue does this PR close? - Closes apache#25578. ## Rationale for this change See the issue and apache#14305. ## What changes are included in this PR? - New CI job that checks if `datafusion-examples` uses subcrates directly which are already exported by the main `datafusion` crate. - Updated the examples to only use the main `datafusion` crate. ## What is the testing strategy for this PR? This PR. ## Are there any user-facing changes? Examples now do not use subcrates directly without needing to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-examplesshould only use thedatafusioncrate #25578.Rationale for this change
See the issue and #14305.
What changes are included in this PR?
datafusion-examplesuses subcrates directly which are already exported by the maindatafusioncrate.datafusioncrate.What is the testing strategy for this PR?
This PR.
Are there any user-facing changes?
Examples now do not use subcrates directly without needing to.