Skip to content

[fix](refresh) fix priv issue of refresh database and table operation - #26793

Merged
xiaokang merged 1 commit into
apache:masterfrom
morningman:refresh_priv
Nov 12, 2023
Merged

[fix](refresh) fix priv issue of refresh database and table operation#26793
xiaokang merged 1 commit into
apache:masterfrom
morningman:refresh_priv

Conversation

@morningman

Copy link
Copy Markdown
Contributor

Proposed changes

The refresh table and refresh database operation are missing catalog info when checking privilege.
This PR fix it

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit a1dd3697cffea951fe463976010d681331f06497, data reload: false

run tpch-sf100 query with default conf and session variables
q1	5222	5104	5059	5059
q2	375	221	197	197
q3	2088	2021	2045	2021
q4	1495	1433	1422	1422
q5	4111	4138	4122	4122
q6	255	135	133	133
q7	2062	1595	1624	1595
q8	2771	2741	2754	2741
q9	10342	10334	10221	10221
q10	3480	3562	3535	3535
q11	372	246	265	246
q12	449	301	300	300
q13	4558	4133	4096	4096
q14	337	289	289	289
q15	671	585	560	560
q16	702	627	597	597
q17	1143	1078	1080	1078
q18	7793	7336	7422	7336
q19	1698	1722	1703	1703
q20	600	365	347	347
q21	4907	4578	4561	4561
q22	549	450	434	434
Total cold run time: 55980 ms
Total hot run time: 52593 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	5000	5075	5219	5075
q2	346	273	278	273
q3	4038	3956	3942	3942
q4	2772	2748	2754	2748
q5	6468	6495	6512	6495
q6	247	127	130	127
q7	3132	2664	2655	2655
q8	4762	4776	4802	4776
q9	17848	17602	17591	17591
q10	4090	4161	4135	4135
q11	761	664	650	650
q12	1001	811	823	811
q13	4305	3952	3892	3892
q14	379	343	353	343
q15	633	570	574	570
q16	783	695	702	695
q17	3876	3858	3920	3858
q18	9452	9105	9241	9105
q19	1846	1790	1778	1778
q20	2395	2044	2022	2022
q21	8747	8721	8716	8716
q22	968	865	898	865
Total cold run time: 83849 ms
Total hot run time: 81122 ms

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.59 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162176262 Bytes

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@xiaokang xiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@xiaokang
xiaokang merged commit 2937b51 into apache:master Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants