Skip to content

Update flink-doris-connector.md - #27329

Merged
morningman merged 4 commits into
apache:masterfrom
cjj2010:patch-1
Dec 17, 2023
Merged

Update flink-doris-connector.md#27329
morningman merged 4 commits into
apache:masterfrom
cjj2010:patch-1

Conversation

@cjj2010

@cjj2010 cjj2010 commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Add String type correspondence between Doris and Flink

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Add String type correspondence between Doris and Flink
@cjj2010

cjj2010 commented Nov 23, 2023

Copy link
Copy Markdown
Contributor Author

@jackwener I have improved the document and helped to review it. Thank you very much

@cjj2010 cjj2010 closed this Dec 4, 2023
@cjj2010 cjj2010 reopened this Dec 16, 2023

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Dec 16, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

JNSimba
JNSimba previously approved these changes Dec 16, 2023

@JNSimba JNSimba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update english doc too

@github-actions github-actions Bot removed the approved Indicates a PR has been approved by one committer. label Dec 16, 2023
@cjj2010

cjj2010 commented Dec 17, 2023

Copy link
Copy Markdown
Contributor Author

Need to update english doc too

ok Now modified

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@morningman
morningman merged commit 03e989b into apache:master Dec 17, 2023
hello-stephen pushed a commit to hello-stephen/doris that referenced this pull request Dec 28, 2023
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants