Skip to content

[bugfix](test)Set the enable_fallback_to_original_planner behavior for 2.1 (#40913)(#40989) #41065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Sep 20, 2024
+51 −40
Merged

[bugfix](test)Set the enable_fallback_to_original_planner behavior for 2.1 (#40913)(#40989) #41065

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5944904
fix
wuwenchi Sep 18, 2024
1651061
[bugfix](testcase) Set the enable_fallback_to_original_planner behavi…
wuwenchi Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 51 additions & 40 deletions regression-test/suites/external_table_p0/iceberg/write/test_iceberg_create_table.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,55 +22,66 @@ suite("test_iceberg_create_table", "p0,external,doris,external_docker,external_d
return
}

String rest_port = context.config.otherConfigs.get("iceberg_rest_uri_port")
String minio_port = context.config.otherConfigs.get("iceberg_minio_port")
String externalEnvIp = context.config.otherConfigs.get("externalEnvIp")
String catalog_name = "test_iceberg_create_table"
String[][] ret = sql"""show variables like 'enable_fallback_to_original_planner';"""
boolean need_set_false = ret.size() == 1 && ret[0][1] == "true"
if (need_set_false) {
sql """ set enable_fallback_to_original_planner=false; """
}

sql """drop catalog if exists ${catalog_name}"""
sql """
CREATE CATALOG ${catalog_name} PROPERTIES (
'type'='iceberg',
'iceberg.catalog.type'='rest',
'uri' = 'http://${externalEnvIp}:${rest_port}',
"s3.access_key" = "admin",
"s3.secret_key" = "password",
"s3.endpoint" = "http://${externalEnvIp}:${minio_port}",
"s3.region" = "us-east-1"
);"""
try {
String rest_port = context.config.otherConfigs.get("iceberg_rest_uri_port")
String minio_port = context.config.otherConfigs.get("iceberg_minio_port")
String externalEnvIp = context.config.otherConfigs.get("externalEnvIp")
String catalog_name = "test_iceberg_create_table"

sql """ switch ${catalog_name} """
sql """drop catalog if exists ${catalog_name}"""
sql """
CREATE CATALOG ${catalog_name} PROPERTIES (
'type'='iceberg',
'iceberg.catalog.type'='rest',
'uri' = 'http://${externalEnvIp}:${rest_port}',
"s3.access_key" = "admin",
"s3.secret_key" = "password",
"s3.endpoint" = "http://${externalEnvIp}:${minio_port}",
"s3.region" = "us-east-1"
);"""

String db1 = catalog_name + "_db1"
String tb1 = db1 + "_tb1"
String tb2 = db1 + "_tb2"
sql """ switch ${catalog_name} """

sql """ drop table if exists ${db1}.${tb1} """
sql """ drop table if exists ${db1}.${tb2} """
sql """ drop database if exists ${db1} """
String db1 = catalog_name + "_db1"
String tb1 = db1 + "_tb1"
String tb2 = db1 + "_tb2"

sql """ create database ${db1} """
sql """ drop table if exists ${db1}.${tb1} """
sql """ drop table if exists ${db1}.${tb2} """
sql """ drop database if exists ${db1} """

test {
sql """ create table ${db1}.${tb1} (id int) engine = olap """
exception "Cannot create olap table out of internal catalog. Make sure 'engine' type is specified when use the catalog: ${catalog_name}"
}
sql """ create database ${db1} """

test {
sql """ create table ${db1}.${tb1} (id int) engine = hive """
exception "java.sql.SQLException: errCode = 2, detailMessage = Iceberg type catalog can only use `iceberg` engine."
}
test {
sql """ create table ${db1}.${tb1} (id int) engine = olap """
exception "Cannot create olap table out of internal catalog. Make sure 'engine' type is specified when use the catalog: ${catalog_name}"
}

test {
sql """ create table ${db1}.${tb1} (id int) engine = jdbc """
exception "java.sql.SQLException: errCode = 2, detailMessage = Iceberg type catalog can only use `iceberg` engine."
}
test {
sql """ create table ${db1}.${tb1} (id int) engine = hive """
exception "java.sql.SQLException: errCode = 2, detailMessage = Iceberg type catalog can only use `iceberg` engine."
}

sql """ create table ${db1}.${tb1} (id int) engine = iceberg """
sql """ create table ${db1}.${tb2} (id int) """
test {
sql """ create table ${db1}.${tb1} (id int) engine = jdbc """
exception "java.sql.SQLException: errCode = 2, detailMessage = Iceberg type catalog can only use `iceberg` engine."
}

sql """ drop table ${db1}.${tb1} """
sql """ drop table ${db1}.${tb2} """
sql """ drop database ${db1} """
sql """ create table ${db1}.${tb1} (id int) engine = iceberg """
sql """ create table ${db1}.${tb2} (id int) """

sql """ drop table ${db1}.${tb1} """
sql """ drop table ${db1}.${tb2} """
sql """ drop database ${db1} """
} finally {
if (need_set_false) {
sql """ set enable_fallback_to_original_planner=true; """
}
}
}