Skip to content

[Opt](Clone) Use log debug instead DCHECK when get_peers_replica_backends reps is empty - #54343

Merged
dataroaring merged 1 commit into
apache:masterfrom
Yukang-Lian:Fix-Missing-Rowset-Dcheck
Aug 10, 2025
Merged

[Opt](Clone) Use log debug instead DCHECK when get_peers_replica_backends reps is empty#54343
dataroaring merged 1 commit into
apache:masterfrom
Yukang-Lian:Fix-Missing-Rowset-Dcheck

Conversation

@Yukang-Lian

@Yukang-Lian Yukang-Lian commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

When tablet is in schema change, get_peers_replica_backends reps will be empty. We should use log debug instead of DCHECK.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian

Yukang-Lian commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator Author

run buildall

@doris-robot

doris-robot commented Aug 5, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33534 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 04d0ccea8d2da3b07dade6ade41fc564f03d3fb4, data reload: false

------ Round 1 ----------------------------------
q1	17618	5436	5234	5234
q2	1947	277	185	185
q3	10303	1405	692	692
q4	10209	1001	534	534
q5	7521	2335	2303	2303
q6	176	177	130	130
q7	900	743	610	610
q8	9286	1300	976	976
q9	6787	5115	5012	5012
q10	6885	2356	1991	1991
q11	453	274	259	259
q12	346	383	227	227
q13	17780	3454	3009	3009
q14	233	241	219	219
q15	535	474	452	452
q16	419	427	369	369
q17	563	811	356	356
q18	7184	7178	6957	6957
q19	1219	977	539	539
q20	313	313	217	217
q21	3439	2453	2261	2261
q22	1059	1020	1002	1002
Total cold run time: 105175 ms
Total hot run time: 33534 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5497	5347	5395	5347
q2	230	300	215	215
q3	2080	2563	2202	2202
q4	1323	1736	1329	1329
q5	4140	4248	4505	4248
q6	220	176	132	132
q7	1955	1991	1815	1815
q8	2578	2507	2469	2469
q9	7256	7374	7249	7249
q10	3139	3394	2871	2871
q11	545	522	490	490
q12	684	758	674	674
q13	3572	3736	3236	3236
q14	323	361	311	311
q15	519	461	459	459
q16	542	624	468	468
q17	1235	1584	1371	1371
q18	12641	7854	7761	7761
q19	6977	971	983	971
q20	2436	2033	1817	1817
q21	14486	4319	4248	4248
q22	1038	1035	990	990
Total cold run time: 73416 ms
Total hot run time: 50673 ms

dataroaring
dataroaring approved these changes Aug 5, 2025
View reviewed changes

@dataroaring dataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2025
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Aug 5, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 170029 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 04d0ccea8d2da3b07dade6ade41fc564f03d3fb4, data reload: false

============================================
query1	1004	411	406	406
query2	6514	1792	1687	1687
query3	6739	232	219	219
query4	27036	23600	22944	22944
query5	4351	656	512	512
query6	344	243	224	224
query7	4643	540	297	297
query8	282	235	227	227
query9	8571	2992	2921	2921
query10	487	344	306	306
query11	15989	15056	14686	14686
query12	188	132	130	130
query13	1658	576	434	434
query14	8688	5848	5968	5848
query15	215	202	166	166
query16	7819	698	494	494
query17	1621	813	652	652
query18	2093	464	324	324
query19	295	231	197	197
query20	159	147	134	134
query21	221	130	111	111
query22	4148	3972	3918	3918
query23	34507	34216	34470	34216
query24	8149	2378	2402	2378
query25	536	514	443	443
query26	930	305	164	164
query27	2610	536	378	378
query28	4210	2314	2323	2314
query29	686	619	492	492
query30	313	231	199	199
query31	897	802	729	729
query32	92	74	80	74
query33	562	447	373	373
query34	847	920	509	509
query35	790	883	777	777
query36	1057	1062	949	949
query37	138	120	90	90
query38	4002	4005	3974	3974
query39	1455	1445	1370	1370
query40	237	145	131	131
query41	62	62	55	55
query42	141	131	128	128
query43	524	494	491	491
query44	1475	860	868	860
query45	205	189	187	187
query46	994	1114	670	670
query47	1807	1881	1758	1758
query48	412	430	312	312
query49	694	537	418	418
query50	716	745	418	418
query51	4163	4273	4149	4149
query52	132	137	122	122
query53	267	295	214	214
query54	670	661	572	572
query55	90	87	96	87
query56	354	363	359	359
query57	1201	1216	1127	1127
query58	340	353	330	330
query59	2702	2720	2539	2539
query60	407	403	423	403
query61	146	123	124	123
query62	846	735	642	642
query63	257	213	215	213
query64	3462	1113	773	773
query65	4237	4143	4150	4143
query66	939	447	340	340
query67	query68	17144	940	885	885
query69	1082	290	287	287
query70	1297	1104	1135	1104
query71	727	314	321	314
query72	9155	2266	2181	2181
query73	3282	727	358	358
query74	9026	8963	8779	8779
query75	7673	3180	2674	2674
query76	8823	1321	814	814
query77	1150	423	334	334
query78	9505	10800	9335	9335
query79	14525	613	581	581
query80	1346	563	497	497
query81	562	265	222	222
query82	433	160	125	125
query83	372	291	270	270
query84	303	102	79	79
query85	958	379	343	343
query86	388	322	289	289
query87	4181	4215	4114	4114
query88	5111	2220	2256	2220
query89	490	388	317	317
query90	2637	227	227	227
query91	224	143	114	114
query92	94	79	68	68
query93	6006	999	660	660
query94	1062	418	280	280
query95	405	333	321	321
query96	528	642	286	286
query97	2666	2762	2594	2594
query98	255	233	226	226
query99	1462	1438	1301	1301
Total cold run time: 305198 ms
Total hot run time: 170029 ms

@doris-robot

doris-robot commented Aug 5, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 32.41 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 04d0ccea8d2da3b07dade6ade41fc564f03d3fb4, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.06	0.07
query4	1.63	0.11	0.12
query5	0.44	0.41	0.42
query6	1.17	0.65	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.54	0.47	0.47
query10	0.53	0.53	0.54
query11	0.16	0.11	0.10
query12	0.15	0.11	0.11
query13	0.65	0.63	0.64
query14	0.92	1.03	1.11
query15	0.94	0.90	0.88
query16	0.39	0.40	0.39
query17	1.08	1.05	1.08
query18	0.22	0.20	0.20
query19	1.89	1.92	1.78
query20	0.02	0.01	0.01
query21	15.40	0.85	0.54
query22	0.77	1.07	0.62
query23	15.09	1.14	0.64
query24	6.82	1.20	0.34
query25	0.40	0.12	0.14
query26	0.69	0.16	0.13
query27	0.06	0.06	0.05
query28	9.88	0.86	0.46
query29	12.58	3.79	3.28
query30	3.08	2.97	3.01
query31	2.81	0.57	0.39
query32	3.23	0.57	0.50
query33	3.05	3.12	3.23
query34	15.66	5.36	4.89
query35	4.88	4.97	4.94
query36	0.73	0.52	0.50
query37	0.10	0.08	0.08
query38	0.06	0.05	0.05
query39	0.03	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 106.83 s
Total hot run time: 32.41 s

@hello-stephen

hello-stephen commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 58.19% (16339/28080)
Line Coverage 47.10% (147496/313136)
Region Coverage 36.13% (110416/305616)
Branch Coverage 38.96% (48989/125757)

@hello-stephen

hello-stephen commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.24% (22390/27562)
Line Coverage 74.00% (231422/312712)
Region Coverage 61.50% (192724/313383)
Branch Coverage 65.36% (83142/127205)

liaoxin01
liaoxin01 approved these changes Aug 7, 2025
View reviewed changes

@liaoxin01 liaoxin01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 86b0357 into apache:master Aug 10, 2025
30 of 33 checks passed
github-actions Bot pushed a commit that referenced this pull request Aug 10, 2025
@Yukang-Lian Your Name
[Opt](Clone) Use log debug instead DCHECK when get_peers_replica_back…
a02469d 
…ends reps is empty (#54343)
@github-actions github-actions Bot mentioned this pull request Aug 10, 2025
Merged
github-actions Bot pushed a commit that referenced this pull request Aug 10, 2025
@Yukang-Lian Your Name
[Opt](Clone) Use log debug instead DCHECK when get_peers_replica_back…
04b19fc 
…ends reps is empty (#54343)
@github-actions github-actions Bot mentioned this pull request Aug 10, 2025
Merged
dataroaring pushed a commit that referenced this pull request Aug 12, 2025
@github-actions @Yukang-Lian
branch-3.0: [Opt](Clone) Use log debug instead DCHECK when get_peers_…
4716900 
…replica_backends reps is empty #54343 (#54529)

Cherry-picked from #54343

Co-authored-by: abmdocrt <lianyukang@selectdb.com>
morrySnow pushed a commit that referenced this pull request Aug 13, 2025
@github-actions @Yukang-Lian
branch-3.1: [Opt](Clone) Use log debug instead DCHECK when get_peers_…
57b9f21 
…replica_backends reps is empty #54343 (#54532)

Cherry-picked from #54343

Co-authored-by: abmdocrt <lianyukang@selectdb.com>
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes
@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.8-merged dev/3.1.0-merged p0_test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Yukang-Lian @hello-stephen @doris-robot @liaoxin01 @dataroaring @morrySnow