[fix](fe) remove table from waitToCommitTxnCountMap in CloudGlobalTransactionMgr when drop table - #59757
Merged
Merged
Conversation
mymeiyi
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
January 12, 2026 06:54
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a resource leak in CloudGlobalTransactionMgr where table metadata was not properly cleaned up when tables are dropped. Additionally, it simplifies the internal data structure by removing unnecessary nesting of maps that used database IDs as keys.
Changes:
- Renamed
clearTableLastTxnIdtoafterDropTableand added cleanup forwaitToCommitTxnCountMap - Simplified
lastTxnIdMapfromMap<Long, Map<Long, Long>>(dbId -> tableId -> txnId) toMap<Long, Long>(tableId -> txnId) - Simplified
txnLastSignatureMapfromMap<Long, Map<Long, Long>>(dbId -> txnId -> signature) toMap<Long, Long>(txnId -> signature) - Changed several methods from public to private as they are only used internally
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| InternalCatalog.java | Updated to call the renamed afterDropTable method instead of clearTableLastTxnId when dropping tables in cloud mode |
| CloudGlobalTransactionMgr.java | Refactored map data structures to remove database ID nesting, added cleanup of waitToCommitTxnCountMap in afterDropTable, and changed visibility of internal methods to private |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32227 ms |
TPC-DS: Total hot run time: 173303 ms |
bobhan1
approved these changes
Jan 13, 2026
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
zzzxl1993
pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Jan 13, 2026
…nsactionMgr when drop table (apache#59757) ### What problem does this PR solve? 1. `CloudGlobalTransactionMgr` does not remove `waitToCommitTxnCountMap` if table is dropped. 2. simplify `lastTxnIdMap` and `txnLastSignatureMap`
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
Mar 18, 2026
…nsactionMgr when drop table (apache#59757) ### What problem does this PR solve? 1. `CloudGlobalTransactionMgr` does not remove `waitToCommitTxnCountMap` if table is dropped. 2. simplify `lastTxnIdMap` and `txnLastSignatureMap`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
CloudGlobalTransactionMgrdoes not removewaitToCommitTxnCountMapif table is dropped.lastTxnIdMapandtxnLastSignatureMapIssue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)