[fix](regression) isolate ann_index_p0 table names - #62178
Merged
airborne12 merged 2 commits intoApr 8, 2026
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
RoanHeNaN
force-pushed
the
fix-ann-index-p0-table-name-isolation
branch
from
April 7, 2026 13:53
3d257a3 to
9c08781
Compare
Contributor
Author
|
run buildall |
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: IVF and IVF_ON_DISK regression cases only executed several ANN queries without asserting their results, and some snapshot queries relied on implicit row order. This could miss regressions in ANN behavior and make the cases flaky.
### Release note
None
### Check List (For Author)
- Test: Regression test
- `./run-regression-test.sh --run -f regression-test/suites/ann_index_p0/ivf_index_test.groovy -forceGenOut`
- `./run-regression-test.sh --run -f regression-test/suites/ann_index_p0/ivf_on_disk_index_test.groovy -forceGenOut`
- Behavior changed: No
- Does this need documentation: No
Contributor
Author
|
run buildall |
yiguolei
approved these changes
Apr 8, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
RoanHeNaN
added a commit
to RoanHeNaN/doris
that referenced
this pull request
Apr 8, 2026
yiguolei
pushed a commit
that referenced
this pull request
Apr 9, 2026
…es (#62215) ## Summary - backport PR #60358, #61160 and #62178 into branch-4.1 as a single commit - add IVF on-disk ANN index support, related cache/runtime changes, and FE session/property updates - bring over ANN regression coverage updates for IVF, IVF on-disk, small-segment and min-train-rows scenarios
7 tasks
morningman
added a commit
to morningman/doris
that referenced
this pull request
Aug 5, 2026
…lect compaction profile BE by tablet replica apache#62178 apache#65552 Backport two upstream regression-test fixes that never reached branch-4.0. Both cause recurring failures in the daily branch-4.0 P0 pipeline. 1. ann_index_basic vs ivf_index_test table-name collision (apache#62178) ann_index_basic and ivf_index_test run in the same regression database (ann_index_p0) and both used tbl_ann_l2 / tbl_ann_ip. With suiteParallel=10 they can run concurrently: FE logs of the failing run show ivf_index_test dropping and recreating tbl_ann_ip 230ms after ann_index_basic created it, then inserting 6 rows. ann_index_basic then reads the neighbor's table by name and fails. This also explains the historical intermittent empty result of sql_ip_asc (query landing between the neighbor's create and publish); the insert itself publishes in ~80ms, so the visibility-window theory behind the waitRowsVisible gate (apache#65942) was wrong, and the 30s gate now times out against the neighbor's 6-row table instead. Rename the shared tables with basic_/ivf_ prefixes as upstream did in 9c226f5 (apache#62178) and drop the gate. ann_index_basic.groovy becomes byte-identical to the upstream post-fix file. ivf_index_test takes only the renames because the upstream file also carries the apache#60358 behavior change (insufficient train rows no longer throws) which branch-4.0 BE does not have. No .out changes needed. 2. test_compaction_profile_action queries an arbitrary BE (apache#65552) The suite built the /api/compaction/profile URL from backendId_to_backendIP.keySet()[0]. On a multi-BE pipeline (4 BEs, replication forced to 3) the chosen BE has ~1/4 chance of not hosting the tablet replica, so the tablet_id filter returns an empty list (observed 5/26 failures; the case is currently muted as DORIS-26131). Derive the endpoint from the BackendId of the selected tablet row as upstream did in fd16ebd (apache#65552); the file becomes byte-identical to the upstream post-fix version. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ann_index_basicto suite-unique namesivf_index_testto suite-unique namesann_index_p0when suites run in parallel against the same regression database