[fix](iceberg) Allow disabling REST catalog view operations - #62986
Merged
Gabriel39 merged 1 commit intoMay 7, 2026
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a REST-catalog-specific switch to skip Iceberg view operations so Doris can still list/load tables against REST catalog implementations that don’t support (or reject) view APIs.
Changes:
- Introduces
iceberg.rest.view-enabled(defaulttrue) inIcebergRestProperties. - Gates view-related calls in
IcebergMetadataOpsbehind the new property for REST catalogs. - Adds unit tests covering the property behavior and verifying
listViews()is skipped when disabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| fe/fe-core/src/main/java/org/apache/doris/datasource/property/metastore/IcebergRestProperties.java | Adds the new REST property and accessor (isIcebergRestViewEnabled()). |
| fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergMetadataOps.java | Centralizes view capability logic via isViewCatalogEnabled() and uses it to guard view operations. |
| fe/fe-core/src/test/java/org/apache/doris/datasource/property/metastore/IcebergRestPropertiesTest.java | Tests default enabled behavior and the false override. |
| fe/fe-core/src/test/java/org/apache/doris/datasource/iceberg/IcebergMetadataOpTest.java | Verifies listTableNames() skips listViews() when view ops are disabled for REST. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1213
to
1215
| if (!isViewCatalogEnabled()) { | ||
| throw new DdlException("Drop Iceberg view is not supported with not view catalog."); | ||
| } |
There was a problem hiding this comment.
The DdlException message here becomes misleading when view ops are disabled via iceberg.rest.view-enabled=false: isViewCatalogEnabled() can return false even though catalog is a ViewCatalog. Consider updating the message (or branching) to indicate that view operations are disabled by configuration, not that the catalog lacks ViewCatalog support.
Contributor
Author
|
run buildall |
Contributor
|
run buildall |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This was referenced May 17, 2026
morningman
pushed a commit
that referenced
this pull request
May 20, 2026
morningman
added
dev/4.0.6-merged
kind/need-document-merged
and removed
dev/4.0.x
dev/4.0.x-conflict
kind/need-document
labels
zhaorongsheng
pushed a commit
to zhaorongsheng/doris
that referenced
this pull request
Jun 4, 2026
…2986) Some Iceberg REST catalog implementations expose table APIs but fail or reject view APIs. Doris currently calls `ViewCatalog.listViews()` while listing tables when the underlying Iceberg catalog implements `ViewCatalog`, so `SHOW TABLES` and table metadata loading can fail even when table listing/loading works. This PR adds a REST catalog property to disable view operations when needed, while keeping the existing default behavior enabled. ### Changes - Add `iceberg.rest.view-enabled` to `IcebergRestProperties`, defaulting to `true`. - Gate Iceberg view operations in `IcebergMetadataOps` for REST catalogs when the property is set to `false`. - Add unit coverage for the new property and for skipping `listViews()` in table listing.
yiguolei
pushed a commit
that referenced
this pull request
Jun 24, 2026
…ns (#63320) ### What problem does this PR solve? Issue Number: None Related PR: #62986 Problem Summary: Backport #62986 to branch-4.1. This allows Iceberg REST catalog users to disable view operations with `iceberg.rest.view-enabled=false` when the REST catalog does not support view endpoints. The default remains enabled. ### Release note Add `iceberg.rest.view-enabled` for Iceberg REST catalog. It defaults to true and can be set to false to skip view operations. ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [x] Yes. Add an opt-out switch for Iceberg REST catalog view operations; default behavior is unchanged. - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> ### Test - `MAVEN_OPTS='-Xmx4g -XX:MaxMetaspaceSize=1g' FE_UT_PARALLEL=1 ./run-fe-ut.sh --run org.apache.doris.datasource.iceberg.IcebergMetadataOpTest,org.apache.doris.datasource.property.metastore.IcebergRestPropertiesTest`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some Iceberg REST catalog implementations expose table APIs but fail or reject view APIs. Doris currently calls
ViewCatalog.listViews()while listing tables when the underlying Iceberg catalog implementsViewCatalog, soSHOW TABLESand table metadata loading can fail even when table listing/loading works.This PR adds a REST catalog property to disable view operations when needed, while keeping the existing default behavior enabled.
Changes
iceberg.rest.view-enabledtoIcebergRestProperties, defaulting totrue.IcebergMetadataOpsfor REST catalogs when the property is set tofalse.listViews()in table listing.Check List
mvn -pl fe-core -am -Dtest=IcebergRestPropertiesTest,IcebergMetadataOpTest -Dcheckstyle.skip=true -DfailIfNoTests=false -Dmaven.build.cache.enabled=false test