branch-4.1:[fix](ldap) Improve LDAP authentication resiliency and diagnostics (#61673) - #63288
Merged
Merged
Conversation
…pache#61673) This PR addresses several issues in the FE LDAP authentication path that could lead to login hangs, indefinite blocking, unstable search latency, and poor observability when the LDAP server is slow or unavailable. The main changes are: - Add configurable LDAP timeouts, `ldap_connect_timeout_ms` and `ldap_read_timeout_ms` (both default to 5000 ms), so LDAP bind and search operations do not block indefinitely. - Fix LDAP search connection management by removing the conflicting JNDI built-in pooling configuration and adding `ldap_search_use_pool` to support both pooled and non-pooled search mode. - Improve diagnosability by adding structured performance logs across the LDAP authentication chain, including password resolution, bind, user lookup, group lookup, cache hit/miss, and authentication result. Together, these changes improve FE LDAP authentication stability, make timeout behavior explicit and configurable, reduce the risk of login stalls, and provide better diagnostics for production issues.
Member
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
skip buildall |
1 similar comment
Contributor
|
skip buildall |
yiguolei
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr: #61673
commitId: ab94e99