[fix](test) fix flaky compaction profile case - #63886
Merged
morningman merged 1 commit intoJun 9, 2026
Merged
Conversation
…file with tablet_id The unfiltered compaction_profiles[0] may belong to other tablets, whose input_data_size could be 0. Move data-size assertions to use tablet_id-filtered profile to ensure we validate our own compaction. (cherry picked from commit 067b66e)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run p0 |
Collaborator
Author
|
run cloud_p0 |
1 similar comment
Collaborator
Author
|
run cloud_p0 |
morningman
approved these changes
Jun 9, 2026
Collaborator
Author
|
For tracking: master already contains the equivalent fix via #61222 (commit 4640c70). That commit applies the same test-side change in |
16 tasks
hello-stephen
pushed a commit
that referenced
this pull request
Jul 16, 2026
) Related PR: #63886 Problem Summary: `test_compaction_profile_action` queried `/api/compaction/profile` on the first backend returned by `SHOW BACKENDS`, independently of the target tablet placement. The profile API reads the selected BE's process-local compaction tracker, so the tablet filter returned an empty list whenever that backend was the one BE outside the target tablet's three-replica set. The branch-4.1 P0 history shows 13 failures in 32 runs. In every failure, the queried first backend was outside the target replica set; in every passing run, it hosted a target replica. This change derives the profile endpoint from the `BackendId` in the same `SHOW TABLETS` row as the selected `TabletId`. The case therefore queries a replica that participates in `trigger_and_wait_compaction` while preserving all existing API assertions.
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
) Related PR: #63886 Problem Summary: `test_compaction_profile_action` queried `/api/compaction/profile` on the first backend returned by `SHOW BACKENDS`, independently of the target tablet placement. The profile API reads the selected BE's process-local compaction tracker, so the tablet filter returned an empty list whenever that backend was the one BE outside the target tablet's three-replica set. The branch-4.1 P0 history shows 13 failures in 32 runs. In every failure, the queried first backend was outside the target replica set; in every passing run, it hosted a target replica. This change derives the profile endpoint from the `BackendId` in the same `SHOW TABLETS` row as the selected `TabletId`. The case therefore queries a replica that participates in `trigger_and_wait_compaction` while preserving all existing API assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix DORIS-25488:
test_compaction_profile_actionwas flaky because it checked input size on the first unfiltered compaction profile, which may belong to another tablet.This PR checks those fields on the profile filtered by the test tablet id.