-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[fix](rewrite rule) Reject mismatched compare plan in PullUpJoinFromUnionAll #65472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9ae1008
1e22ed7
eb253dd
2853127
c5e5bc0
91b571b
87ad4bf
f5cea12
b9e5064
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ | |
| import org.apache.doris.catalog.Column; | ||
| import org.apache.doris.catalog.OlapTable; | ||
| import org.apache.doris.catalog.Table; | ||
| import org.apache.doris.catalog.constraint.TableIdentifier; | ||
| import org.apache.doris.catalog.stream.OlapTableStreamWrapper; | ||
| import org.apache.doris.catalog.stream.StreamReadMode; | ||
| import org.apache.doris.common.IdGenerator; | ||
|
|
@@ -464,6 +465,30 @@ public LogicalOlapTableStreamScan withReadMode(StreamReadMode readMode) { | |
| scanParams, readMode)); | ||
| } | ||
|
|
||
| @Override | ||
| protected boolean hasSameTableIdentity(LogicalCatalogRelation other) { | ||
| if (!Utils.isSameClass(this, other)) { | ||
| return false; | ||
| } | ||
| LogicalOlapTableStreamScan that = (LogicalOlapTableStreamScan) other; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check other type first
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. before call this function, previous function had check class equals
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added |
||
| return Objects.equals(getTable().getStreamDbId(), that.getTable().getStreamDbId()) | ||
| && Objects.equals(getTable().getStreamId(), that.getTable().getStreamId()) | ||
| && new TableIdentifier(getTable().getBaseTable()) | ||
| .equals(new TableIdentifier(that.getTable().getBaseTable())); | ||
| } | ||
|
|
||
| @Override | ||
| protected boolean hasSameScanState(LogicalCatalogRelation other) { | ||
| if (!Utils.isSameClass(this, other)) { | ||
| return false; | ||
| } | ||
| LogicalOlapTableStreamScan that = (LogicalOlapTableStreamScan) other; | ||
| return super.hasSameScanState(other) | ||
| && readMode == that.readMode | ||
| && getTable().getStreamKeysType() == that.getTable().getStreamKeysType() | ||
| && Objects.equals(getTable().getOutputUpdateMap(), that.getTable().getOutputUpdateMap()); | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
| return visitor.visitLogicalOlapTableStreamScan(this, context); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.