branch-4.0: [fix](test) Stabilize lineage skip internal schema test #65235 - #65510
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](test) Stabilize lineage skip internal schema test #65235#65510github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Related PR: #61004 Problem Summary: `LineageUtilsSkipTest.testSkipInternalSchemaInsert` could fail intermittently in FE UT with `Failed to acquire catalog lock. Try again`. Root cause: In `LineageUtilsSkipTest.beforeCluster()`, the test enabled `FeConstants.enableInternalSchemaDb` before the mocked FE cluster started. This allowed the background `InternalSchemaInitializer` to run during test startup. The background initializer and the test method both performed DDL, so they could race on the catalog lock used by `InternalCatalog.createDb()`. This PR keeps the background internal schema initializer disabled for the unit test and creates the required internal schema synchronously in `runBeforeAll()`. | File | Change Description | |------|--------------------| | `LineageUtilsSkipTest.java` | Stop enabling the background internal schema initializer, create the internal schema synchronously before the test body, and remove duplicate per-test initialization. |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65235