branch-4.0: [fix](fe) Reuse Ranger Doris access controller #65570 - #65613
Merged
Conversation
### What problem does this PR solve? Issue Number: close #65524 Related PR: #45645 Problem Summary: When Ranger Doris authorization is enabled, constructing a `RangerDorisAccessController` initializes a Ranger plugin and starts a `PolicyRefresher` background thread. Metadata checkpoints create temporary `Env` instances, and each `Env` previously received a newly constructed Ranger Doris access controller. Destroying the checkpoint `Env` only released the `Env` reference, so the refresher threads remained alive. A successful checkpoint could therefore leak two `PolicyRefresher` threads. This change uses an initialization-on-demand holder in `RangerDorisAccessControllerFactory` so all `Env` instances in the FE process share one lazily initialized controller and one refresher thread. The unit test verifies that multiple factory instances construct and return only one controller.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
morningman
approved these changes
Jul 15, 2026
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65570