[branch-4.1][fix](docker) initialize external MS argument - #65926
Merged
yiguolei merged 1 commit intoJul 23, 2026
Merged
Conversation
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
|
pick #57236 related modify for external ms cluster |
hello-stephen
force-pushed
the
agent/fix-external-ms-init-branch-4.1
branch
from
July 23, 2026 03:28
fdc5906 to
aab24e8
Compare
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
skip buildall |
yiguolei
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TeamCity S3 Docker build #203806 reran branch-4.1 after #64623 and exposed the next first error shared by all 192 failed suites:
This is a partial-backport gap. branch-4.1 already contains the
--external-msargument and passesexternal_ms_clustertoCluster.new, but missed the corresponding local-variable assignment from #57236.Jira: DORIS-26392
Build: http://172.20.48.17:8111/build/203806
Reference: #57236
What is changed?
Initialize
external_ms_clusterfromargs.external_msbefore the cloud/non-cloud branch.This PR intentionally does not backport the full multi-cluster feature or add new validation behavior. It only restores the missing assignment while preserving the existing branch-4.1 behavior.
Check List
git diff --checkpython3 -m py_compile docker/runtime/doris-compose/command.py docker/runtime/doris-compose/cluster.pyCluster.newuses it.