[fix](exec) preserve NULL in pushed-down CHAR MIN/MAX#65952
Open
Mryange wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve? Issue Number: N/A Problem Summary: Nullable CHAR values returned by the zone-map min/max path were rebuilt through a non-null Field, converting NULL into an empty string. Preserve the StringRef null marker when removing CHAR padding. ### Release note Fix incorrect MIN results for nullable CHAR columns with min/max aggregation pushdown. ### Check List (For Author) - Test: Added VGenericIteratorsTest.StatisticsIteratorPreservesNullForNullableChar; manual multi-bucket reproduction verified after the BE fix. - Behavior changed: Yes; nullable CHAR MIN preserves NULL semantics. - Does this need documentation: No.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
|
Codex automated review failed and did not complete. Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Jul 28th, 2026 5:08 PM. Please inspect the workflow logs and rerun the review after the underlying issue is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
MINon a nullable CHAR column could return an empty string when string min/max aggregation was pushed down to multiple tablets. The zone-map reader produced NULL correctly, but the CHAR padding cleanup rebuilt each value through a non-nullField, convertingStringRef{nullptr, 0}into an empty string. Preserve the original StringRef throughinsert_data()so NULL remains NULL while CHAR padding is still removed.Release note
Fix incorrect
MINresults for nullable CHAR columns when min/max aggregation pushdown is enabled.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)