branch-4.0: [fix](rewrite rule) Reject mismatched compare plan in PullUpJoinFromUnionAll #65472 - #65999
Merged
Conversation
…nionAll (apache#65472) Avoid comparing and remapping join inputs as equivalent when the common-side projects expose different output arity. This keeps the union pull-up rewrite aligned with the actual plan shape and adds focused coverage for the comparator and rewrite guard. Key changes: - Add an output-size guard before comparing plan nodes in PullUpJoinFromUnionAll. - Add a FE unit test that covers both the comparator and the rewrite path. Unit Test: - PullUpJoinFromUnionAllTest relate PR: apache#28682
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run feut |
morningman
approved these changes
Jul 27, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick: #65472