Skip to content

[fix](ci) Increase automated code review timeout to 120 minutes - #67844

Merged
hello-stephen merged 1 commit into
apache:masterfrom
shuke987:codex/review-timeout-120min
Sep 11, 2026
Merged

hello-stephen merged 1 commit into
apache:masterfrom
shuke987:codex/review-timeout-120min

Conversation

@shuke987

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:

The automated review of #67687 hit the 90-minute step timeout while finishing its report (failed run); its formal review was submitted about 23 seconds later.

Increase the review step timeout from 90 to 120 minutes. Raise the job timeout from 208 to 238 minutes and update the budget comment, preserving 8 minutes for auth synchronization and 12 minutes for runner setup and post-job cleanup.

Release note

None

Check List (For Author)

  • Test:
    • Unit Test: all 18 existing test_review_auth_quarantine.py tests passed against the modified workflow using fake OSS, Codex, and GitHub services.
    • Manual test: parsed the YAML and verified the 120-minute review limit, 218-minute pre-finalization budget, 8-minute auth sync, and 12-minute reserve within the 238-minute job limit. Confirmed no other parsed workflow changes; patch whitespace check passed.
  • Behavior changed:
    • Yes. Automated reviews may run for up to 120 minutes.
  • Does this need documentation?
    • No. The workflow budget comment is updated.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Problem Summary:

The automated review of apache#67687 hit the 90-minute step timeout while finishing its report ([failed run](https://github.com/apache/doris/actions/runs/34488778375/job/102909763020)); its [formal review](apache#67687 (review)) was submitted about 23 seconds later.

Increase the review step timeout from 90 to 120 minutes. Raise the job timeout from 208 to 238 minutes and update the budget comment, preserving 8 minutes for auth synchronization and 12 minutes for runner setup and post-job cleanup.

### Release note

None

### Check List (For Author)

- Test:
  - [x] Unit Test: all 18 existing `test_review_auth_quarantine.py` tests passed against the modified workflow using fake OSS, Codex, and GitHub services.
  - [x] Manual test: parsed the YAML and verified the 120-minute review limit, 218-minute pre-finalization budget, 8-minute auth sync, and 12-minute reserve within the 238-minute job limit. Confirmed no other parsed workflow changes; patch whitespace check passed.
- Behavior changed:
  - [x] Yes. Automated reviews may run for up to 120 minutes.
- Does this need documentation?
  - [x] No. The workflow budget comment is updated.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

Copy link
Copy Markdown
Contributor Author

skip buildall

@hello-stephen
hello-stephen merged commit 1b91bfa into apache:master Sep 11, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants