Skip to content

Design of MaterializedViewQuery #6977

Description

@leventov

Currently, #5556 implements it as MaterializedViewQuery and MaterializedViewQueryQueryToolChest, i. e. in the same type framework as Query and QueryToolChest. However, MaterializedViewQuery and MaterializedViewQueryQueryToolChest are shallow and pass-through classes. MaterializedViewQueryQueryToolChest couldn't sensibly return something from getResultTypeReference(), so I wonder why it didn't throw NPE in DirectDruidClient before, but I hit this problem in my change #6898.

There should probably be an abstraction like "query modifier" and other parts of the infrastructure should recognize it.

cc @zhangxinyu1 @jihoonson

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions