Skip to content

feat: simd division expression#19686

Merged
clintropolis merged 1 commit into
apache:masterfrom
clintropolis:simd-divide
Jul 15, 2026
Merged

feat: simd division expression#19686
clintropolis merged 1 commit into
apache:masterfrom
clintropolis:simd-divide

Conversation

@clintropolis

Copy link
Copy Markdown
Member

Description

Adds simd optimized division expression, though no long/long support since there is no simd intrinsic for it so it keeps the current path. Measurements look pretty nice:

10: mixed math - 2 longs, 1 double
SELECT SUM((long1 * long2) / double1) FROM expressions
11: mixed math - 2 longs, 1 double, 1 float
SELECT SUM(float3 + ((long1 * long4)/double1)) FROM expressions
12: mixed math - 3 longs, 1 double, 1 float
SELECT SUM(long5 - (float3 + ((long1 * long4)/double1))) FROM expressions
Benchmark                        (complexCompression)  (deferExpressionDimensions)  (jsonObjectStorageEncoding)  (query)  (rowsPerSegment)  (schemaType)  (storageType)  (stringEncoding)  (useVectorApi)  (vectorize)  Mode  Cnt   Score   Error  Units
SqlExpressionBenchmark.querySql                  NONE                 singleString                        SMILE       10           1500000      explicit           MMAP              UTF8           false        force  avgt    5  23.836 ± 1.070  ms/op
SqlExpressionBenchmark.querySql                  NONE                 singleString                        SMILE       10           1500000      explicit           MMAP              UTF8            true        force  avgt    5  13.667 ± 1.304  ms/op
SqlExpressionBenchmark.querySql                  NONE                 singleString                        SMILE       11           1500000      explicit           MMAP              UTF8           false        force  avgt    5  27.081 ± 0.958  ms/op
SqlExpressionBenchmark.querySql                  NONE                 singleString                        SMILE       11           1500000      explicit           MMAP              UTF8            true        force  avgt    5  15.858 ± 0.896  ms/op
SqlExpressionBenchmark.querySql                  NONE                 singleString                        SMILE       12           1500000      explicit           MMAP              UTF8           false        force  avgt    5  44.236 ± 1.534  ms/op
SqlExpressionBenchmark.querySql                  NONE                 singleString                        SMILE       12           1500000      explicit           MMAP              UTF8            true        force  avgt    5  26.604 ± 0.419  ms/op

@jtuglu1 jtuglu1 added this to the 38.0.0 milestone Jul 15, 2026

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.

Reviewed 8 of 8 changed files.


This is an automated review by Codex GPT-5.6-Sol

@clintropolis
clintropolis merged commit 87943a1 into apache:master Jul 15, 2026
85 of 90 checks passed
@clintropolis
clintropolis deleted the simd-divide branch July 15, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants