Skip to content

prevent NPE from suppressing actual exception - #5146

Merged
gianm merged 1 commit into
apache:masterfrom
pjain1:fix_npe_kit
Dec 12, 2017
Merged

prevent NPE from suppressing actual exception#5146
gianm merged 1 commit into
apache:masterfrom
pjain1:fix_npe_kit

Conversation

@pjain1

@pjain1 pjain1 commented Dec 7, 2017

Copy link
Copy Markdown
Member

If an exception happens before publishExecService is created then in finally block that exception can be suppressed with NPE from publishExecService.shutdownNow() statement.

@pjain1 pjain1 added this to the 0.12.0 milestone Dec 7, 2017
@himanshug

Copy link
Copy Markdown
Contributor

👍

@gianm

gianm commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

LGTM

@gianm
gianm merged commit 677e24b into apache:master Dec 12, 2017
seoeun25 added a commit to seoeun25/incubator-druid that referenced this pull request Jan 10, 2020
* Kafka Index Task that supports Incremental handoffs apache#4815

* prevent NPE from supressing actual exception (apache#5146)

* prevent npe on mismatch between number of kafka partitions and task count (apache#5139)

* Throw away rows with timestamps beyond long bounds in kafka indexing (apache#5215) (apache#5232)

* Fix state check bug in Kafka Index Task (apache#5204) (apache#5248)
@pjain1
pjain1 deleted the fix_npe_kit branch March 28, 2020 14:52
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants