Add metamx emitter, http clients, and metrics packages to druid java-util - #5289
Merged
Conversation
Contributor
Author
|
This PR will cause the native libraries for hyperic sigar that are packaged in the com.metamx java-util jar to be packaged in the druid java-util jar. If anyone has objections to this, please comment on this PR. |
leventov
reviewed
Jan 24, 2018
| final int readByte = in.read(); | ||
| if (expectedBytes[i] != (byte) readByte) { | ||
| Assert.assertEquals(String.format("%s[%d", Arrays.toString(expectedBytes), i), expectedBytes[i], readByte); | ||
| Assert.assertEquals(StringUtils.format("%s[%d", Arrays.toString(expectedBytes), i), expectedBytes[i], readByte); |
Member
|
Also fix inspection problem |
Contributor
|
LGTM once the CI is passing. |
himanshug
approved these changes
Jan 24, 2018
jon-wei
added a commit
to jon-wei/druid
that referenced
this pull request
Feb 14, 2018
…util (apache#5289) * Add metamx java-util emitter, http clients, and metrics packages to druid java-util * Remove metamx java-util from pom.xml files * Checkstyle fixes * Import fix * TeamCity inspection fixes * Use slf4j, move some version defs to master pom.xml * Use parent jvm-attach-api and maven-surefire-plugin versions * Add ] to log msg, suppress inspection
gianm
pushed a commit
that referenced
this pull request
Feb 15, 2018
…druid java-util (#5289) (#5387) * Add metamx emitter, http clients, and metrics packages to druid java-util (#5289) * Add metamx java-util emitter, http clients, and metrics packages to druid java-util * Remove metamx java-util from pom.xml files * Checkstyle fixes * Import fix * TeamCity inspection fixes * Use slf4j, move some version defs to master pom.xml * Use parent jvm-attach-api and maven-surefire-plugin versions * Add ] to log msg, suppress inspection * Remove extra files, fix HttpPostEmitter compile
This was referenced Feb 23, 2018
Contributor
|
Changed milestone since we did a backport. |
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…util (apache#5289) * Add metamx java-util emitter, http clients, and metrics packages to druid java-util * Remove metamx java-util from pom.xml files * Checkstyle fixes * Import fix * TeamCity inspection fixes * Use slf4j, move some version defs to master pom.xml * Use parent jvm-attach-api and maven-surefire-plugin versions * Add ] to log msg, suppress inspection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the emitter, http.client, and metrics packages from metamx's java-util to druid's own java-util module.
This is tagged with Release Notes because this changes configuration properties to use
io.druid.java.util.*names instead ofcom.metamx.*.