ArrayAggregation: Use long to avoid overflow - #5544
Merged
Merged
Conversation
gianm
reviewed
Mar 28, 2018
Contributor
There was a problem hiding this comment.
BufferArrayGrouper.requiredBufferCapacity must also be modified to return a long.
Also, please add a regression test for this.
And thank you for finding the bug!
niketh
force-pushed
the
avoid-overflow
branch
2 times, most recently
from
March 28, 2018 16:34
d1e5dc4 to
dc3a529
Compare
gianm
approved these changes
Mar 28, 2018
gianm
left a comment
gianm
left a comment
Contributor
There was a problem hiding this comment.
LGTM after style fixes.
[ERROR] /home/travis/build/druid-io/druid/processing/src/main/java/io/druid/query/groupby/epinephelinae/BufferArrayGrouper.java:75:15: 'typecast' is not followed by whitespace. [WhitespaceAfter]
Contributor
|
LGTM. @niketh thanks for the fix! |
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 9, 2018
* ArrayAggregation: Use long to avoid overflow * Add Tests
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Apr 9, 2018
* ArrayAggregation: Use long to avoid overflow * Add Tests
fjy
pushed a commit
that referenced
this pull request
Apr 10, 2018
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
* ArrayAggregation: Use long to avoid overflow * Add Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jihoonson Nasty bug, overflow error can be easily overlooked. Fix for #5203