Remove unused config - #5564
Merged
Merged
Conversation
niketh
force-pushed
the
remove-unused-config
branch
from
April 2, 2018 22:40
61e10d3 to
0ad8cfd
Compare
gianm
approved these changes
Apr 2, 2018
gianm
left a comment
gianm
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I was surprised to learn that these configs are not being checked here, but are bound some other place.
Contributor
|
Please check the CI failure. |
niketh
force-pushed
the
remove-unused-config
branch
from
April 3, 2018 01:22
18a62c7 to
ac00f44
Compare
Contributor
Author
|
@gianm @jihoonson Also do you like the idea of combining |
Contributor
|
@niketh How would you suggest combining them? It isn't clear to me how it would be done, since one is updated dynamically and one is based on static configuration. |
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
* Remove unused config * Fix failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gianm I understand that CoordinatorDynamicConfig allows dynamic configurations. But, I think we can combine DruidCoordinatorConfig.java and CoordinatorDynamicConfig.java.