change header in overlord console; minor querydoc change - #5625
Conversation
| <body> | ||
| <div class="container"> | ||
| <div class="heading">Coordinator Console</div> | ||
| <div class="heading">Overlord Console</div> |
There was a problem hiding this comment.
This should be a separate PR from the doc change (since they are unrelated).
|
|
||
| ##### Configurations for groupBy v2 | ||
|
|
||
| Supported runtime properties: |
There was a problem hiding this comment.
This line should stay in, I think.
|
|
||
| #### Commonly tuned configurations | ||
|
|
||
| This section describes the configurations for groupBy queries. You can set these in the runtime.properties on broker, historical, and MiddleManager nodes, or as query-specific configurations by adding them to query contexts. All runtime properties are prefixed by `druid.query.groupBy`. |
There was a problem hiding this comment.
Hmm now that I read this again I think the original language kind of confusing. It was probably written with groupBy v1 in mind, where the context settings and runtime parameters had more in common. Suggest something like this instead:
This section describes the configurations for groupBy queries. You can set the runtime properties in the
runtime.propertiesfile on broker, historical, and MiddleManager nodes. You can set the query context parameters through the query context.
And link "query context" to the page on that (query-context.html).
Hopefully that makes things make more sense to the reader.
* change header in overlord console; minor querydoc change * remove change to overlord console * address Gian comments
* change header in overlord console; minor querydoc change * remove change to overlord console * address Gian comments
4 participants
No description provided.