[Backport] ParallelCombiner: Fix buffer leak on exception in "combine". - #5633
Merged
Conversation
…5630) Once a buffer is acquired, we need to make sure to release it if an exception is thrown before the closeable iterator is created.
Contributor
|
@gianm just noticed that, you are using a branch 0.12.0 to prepare a release candidate0.12.1, i thought that can confuse ppls where instead of pulling the tag 0.12.0 they will pull that branch and think they are using 0.12.0. Maybe it is something that we should reconsider? |
Contributor
Author
|
@b-slim hmm, I was treating the 0.12.0 branch as more of a 0.12.x branch, but the name is in fact misleading then. I could redo the branches to restore 0.12.0 to its old state and to make a new 0.12.1 branch. Do you (or anyone else listening) think it's worth it? |
Contributor
|
i know at least one instance where a person was pulling from branch instead of tag and IMO it is common especially in the Apache Hadoop Community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5630 to 0.12.0.