Detailed error message when unable to create temp dir - #5648
Conversation
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
Thanks @yuppie-flu! This will be the change that pre-empts a hundred confused mailing list threads :)
I left some comments suggesting minor changes to the error message.
There was a problem hiding this comment.
Nit: error messages with line breaks can make it tougher to grep through logs, and also can look weird, so I would leave it out.
There was a problem hiding this comment.
I would also include the current java.io.tmpdir property here, something like, "Failed to create temporary directory in[%s]" & format that with java.io.tmpdir. Using ISE instead of IllegalStateException can help here (it does string formatting in the constructor).
There was a problem hiding this comment.
Grammar: "Make sure the java.io.tmpdir property is set to an existing and writable directory."
b250037 to
04ec201
Compare
|
What is going on with tests on CI? Failures look very random... |
|
We have been having some trouble with the CI infra recently - sorry about that. I restarted the two tests that didn't pass. |
4 participants
Fixes #5576