Fix for when Hadoop dataSource inputSpec is specified multiple times. - #5790
Merged
Conversation
This feature was introduced in apache#5717 but it didn't work in production because this magical rewriter code wasn't also modified. Now, it is.
jihoonson
reviewed
May 22, 2018
jihoonson
left a comment
jihoonson
left a comment
Contributor
There was a problem hiding this comment.
LGTM. +1 after Travis.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
May 23, 2018
…apache#5790) This feature was introduced in apache#5717 but it didn't work in production because this magical rewriter code wasn't also modified. Now, it is.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
May 23, 2018
…apache#5790) This feature was introduced in apache#5717 but it didn't work in production because this magical rewriter code wasn't also modified. Now, it is.
Contributor
|
Can we include this in 0.12.2? |
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Jul 5, 2018
…apache#5790) This feature was introduced in apache#5717 but it didn't work in production because this magical rewriter code wasn't also modified. Now, it is.
fjy
pushed a commit
that referenced
this pull request
Jul 5, 2018
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Jul 20, 2018
…apache#5790) (apache#5942) This feature was introduced in apache#5717 but it didn't work in production because this magical rewriter code wasn't also modified. Now, it is.
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…apache#5790) This feature was introduced in apache#5717 but it didn't work in production because this magical rewriter code wasn't also modified. Now, it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature was introduced in #5717 but it didn't work in production
because this magical rewriter code wasn't also modified. Now, it is.
I even tested it this time.